Syndesis: [api client connector] specify security block is not centered correctly

Created on 11 Jun 2019 · 5Comments · Source: syndesisio/syndesis

This is a...


[ ] Feature request
[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Documentation issue or request

Description

screenshot_20190611_132057

Edit: Also the radio element is not aligned with the label.

cabug closemigrated grouui prip2 sourcqe

Source

mcada

Most helpful comment

I'd classify that as an enhancement and do it for 7.5, with all the required time to evaluate the fallback.

riccardo-forina on 13 Jun 2019

👍2

All 5 comments

https://github.com/syndesisio/syndesis-react/pull/461 fixes this

riccardo-forina on 13 Jun 2019

Edit: Also the radio element is not aligned with the label.

To fix that across the board, I think we should change the body's line-height to either 1.6 (PF3 default) or --pf-global--LineHeight--md (PF4 default, which is 1.5). I think that would be a good change in general. That has some far reaching implications, and might require some other updates as it would impact the line-height on most/all pages. I'm down for giving it a try. WDYT @dongniwang? Should I try and do that today?

mcoker on 13 Jun 2019

@mcoker - Is there a way to do some investigative work for this? Would it be a quick fix which means they it's something you can wrap up today? My main concern is whether or not changing the line height affect the display of other UI elements, like checkboxes, text input field, or icons (info icons)?