Syndesis: Label color improvements

[rhuss]

This is a...

[X] Feature request
[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Documentation issue or request

Actually, the label colours have been consolidated to less colours, which is a good thing imo.

However, I think it goes a bit over the top for label groups which are supposed to be allowed multiple times (like group/ or notif/)

So my suggestion is:

• To use a single background colour for label groups where is only one element is supposed to be present (prio/, size/, ...). Not sure why cat/feature is different from the scheme.
• For others, where are several possibilities allowed (cat/, group/, especially notif/ which targets different teams and its hard to depict from the colour to which team it belongs). For those I suggest to use different but similar colours (e.g. shades of green) and for notif/ totally separate colours.

[gashcrumb]

I've been feeling the initial grouping qualifier on our labels a bit over-engineered to be honest. So consistent label colors and pulling the grouping out of the text of the label might be much better.

[gashcrumb]

And see, lookit, this issue has cat/discussion and cat/feature and they're different colors :-)

I rest my case.

[gashcrumb]

One other thought, the notif category is meaningless as an actual notification of any kind. Using triage as a flag to indicate an issue needs triaging is fair enough though.

[rhuss]

@gashcrumb cat/feature is the only exception of the rule. not sure why though.

[rhuss]

wrt regarding stripping the prefix: I'm using some tooling which is not colour aware so it would be super awesome if we could keep that.

[gashcrumb]

Yep, that's cool, I'm fine with that.

[dongniwang]

One related question -

Is it possible to have the bot automatically tag syndesisio/uxd when a label group/uxd or notif/uxd is applied?

[gashcrumb]

That'd be a good case for any of the notif labels there if it caused a bot to add a comment with the relevant group like @syndesisio/uxd

[dongniwang]

What's the difference between pure-bot and syndesis-bot?

Also, would it be possible to have a bot automatically add an issue to a project based on a certain label? e.g. with the label notif/uxd, add the issue to https://github.com/syndesisio/syndesis/projects/2

[rhuss]

I think we should remove group/uxd (as it is not a functional group as the other members of this category) and just stick with notif/uxd so there would be no need for an extra label to filer on for the UXD team.

[rhuss]

Also, would it be possible to have a bot automatically add an issue to a project based on a certain label? e.g. with the label notif/uxd, add the issue to

Yes, that should be possible. Please feel free to open an issue over there at https://github.com/syndesisio/pure-bot

[heiko-braun]

I wanted features to be green and bugs red. Along these color changes my proposal would be to call it ‘feature’ and ‘bug’ and leave the remaining ‘cat/*’ as is.

[heiko-braun]

I agree with stans comment about notif

[heiko-braun]

To add some background info, this is what inspired that changes:

The actual categories and colors are less important. what matters is the use of consistent color per category. The part that resonated with me was the red/green/blue separation for bugs/features/enhancements.

(Taken from https://robinpowered.com/blog/best-practice-system-for-organizing-and-tagging-github-issues/)

[rhuss]

@heiko-braun But why has every group/ and cat/ the same color when there can be multiple of these labels applied at the same time ? Your colour scheme above implies a single selection per category, then the same colour makes sense.

For the case of multiple possible labels I'd like a differentiation in the colour (and if its only a shade) so that ideally every label attached to an issue has different colours (also a good litmus test to check whether labelling was applied correctly: If two labels with the same colours are applied, then a supposed to be single selection was applied twice, like adding prio/p0 and prio/p1 at the same time).

[dongniwang]

I think we should remove group/uxd (as it is not a functional group as the other members of this category) and just stick with notif/uxd so there would be no need for an extra label to filer on for the UXD team.

What do you all think about Roland's proposal ^^? @syndesisio/uxd

Also, just open this issue for the bot to automatically notify uxd. @rhuss @heiko-braun

[amysueg]

@dongniwang As long as we triage the "notify/uxd"-labeled items and treat them the way we've been treating group/uxd items, I agree that we don't need the nuanced differentiation and potential confusion of keeping both.

[rhuss]

To put the label "group/uxd" in a historical context, that label was meant at the time to be applied to issues and PRs which result in a UXD document stored within the syndesis repo. AFAIK, UXD artefacts are not stored anymore in the syndesis mono repo, so it would make sense to remove the "group/uxd" label.

[dongniwang]

@rhuss - this is probably really nit-picky, but I was wondering if we can increase the color contrast of the notif label set. The current color combination of purple background and black text makes it really hard to scan...

[gashcrumb]

@dongniwang if it helps you should also have permissions to update 'em -> https://github.com/syndesisio/syndesis/labels

I agree, the purple is a bit dark.

[rhuss]

Yeah, I think the labels should please those who are working with them mostly. best negotiate with @heiko-braun but I think increasing the contrast makes sense for sure.

[heiko-braun]

@dongniwang let's iterate on this. I have changed it to use a white font colour - better?

[heiko-braun]

I was thinking about making bug and feature top level items, i.e turning them into Bug and Feature. Any objections?

[stale[bot]]

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!