Sylius: Custom bulk action cannot use selected item ids

Created on 2 Apr 2020  路  8Comments  路  Source: Sylius/Sylius

Sylius version affected: 1.7

Description
In https://github.com/Sylius/Sylius/commit/4013e51dfdd3ff7d5bd00f2751308eac2bb3149a#diff-58eafbd631b5c6126f098f7e6808604eR27 bulk checkboxes have been bound to #bulk-delete form so it is not possible to use them for custom actions as current documentation mentioned

ref slack discussion

Bug

All 8 comments

Hello Radek,

That's true, we by mistake coupled bulk actions with delete. Is it something that is blocking you? Would you like to revert the PR that you have mentioned to the original form (or propose something js free with the same behavior)?

Since mentioned commit has no added feature, revert would be probably the best solution for now. We've overrided problematic template so it is not blocking for us but it could be annoying for somebody other who has to debug it again.

Could you open a PR with a fix, please? It should be added to the 1.7 branch. Then it will be added to the nearest patch release (probably released in less than 2 weeks)

Also, let me apologize for the long response time.

I made a PR to revert the commit mentionned by @radekbernatek

@lchrusciel @pamil @Zales0123 could you plz merge the revert, it's blocking the bulk actions from working on >1.7.
Thx !

We are blocked by the red build on https://github.com/Sylius/Sylius/pull/11708. Once it will be green I will merge it and we should tag fixed version pretty soon

Any news ?

Should be fixed at https://github.com/Sylius/Sylius/releases/tag/v1.7.7 and further versions. Can you confirm?

Was this page helpful?
0 / 5 - 0 ratings

Related issues

stefandoorn picture stefandoorn  路  3Comments

xleliberty picture xleliberty  路  3Comments

mikemix picture mikemix  路  3Comments

loic425 picture loic425  路  3Comments

loic425 picture loic425  路  3Comments