Sylius: Wrong method in example on documentation of attributes

Created on 9 Oct 2017  Â·  3Comments  Â·  Source: Sylius/Sylius

| Q | A
| ---------------- | -----
| Bug report? | yes
| Feature request? | no
| BC Break report? | no
| RFC? | no
| Sylius version | 1.0.0

$attributeFactory->createWithType($type) should be $attributeFactory->createTyped($type)

See:
https://github.com/Sylius/Sylius/blob/362ef04e123b36c11bdb891bbf83d9b67a81c99c/docs/book/products/attributes.rst#L41
https://github.com/Sylius/Sylius/blob/362ef04e123b36c11bdb891bbf83d9b67a81c99c/docs/book/products/attributes.rst#L51

Documentation Good First Issue Potential Bug

Most helpful comment

I hope you don't mind, I took the liberty of creating a pull request for this?

All 3 comments

@reyostallenberg thank you for reporting this. Could you open a PR with this change?

I hope you don't mind, I took the liberty of creating a pull request for this?

Great!

On Oct 10, 2017 8:52 PM, "Geoff Garbers" notifications@github.com wrote:

I hope you don't mind, I took the liberty of creating a pull request for
this?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Sylius/Sylius/issues/8799#issuecomment-335571710, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADac0i7H4IWHq3ZMFAqYjnKCPChUnqK-ks5sq7z4gaJpZM4Pyfpl
.

Was this page helpful?
0 / 5 - 0 ratings