Sylius: TaxiationBundle can't be used as a standalone Bundle
Sylius version affected: 1.5.3
Description
TaxationBundle must not depends of Core component.
Steps to reproduce
See https://github.com/Sylius/Sylius/blob/master/src/Sylius/Bundle/TaxationBundle/Resources/config/services.xml, in line 20 <parameter key="sylius.tax_calculation_strategy.interface">Sylius\Component\Core\Taxation\Strategy\TaxCalculationStrategyInterface</parameter>
Possible Solution
Add interface in Taxiation component/bundle
hmonglee
All 3 comments
Hey @Zales0123 , this should be in CoreBundle ?
<service id="sylius.registry.tax_calculation_strategy" class="Sylius\Component\Registry\PrioritizedServiceRegistry">
<argument>%sylius.tax_calculation_strategy.interface%</argument>
<argument>Tax calculation strategy</argument>
</service>
hmonglee
on 25 Sep 2019
Yes, it should be fixed.
Can you open a PR?
lchrusciel
on 27 Sep 2019
Fixed in #10995.
pamil
on 22 Jan 2020
Related issues
inssein
路
3Comments
mikemix
路
3Comments
Chrysweel
路
3Comments
ping86
路
3Comments
javiereguiluz
路
3Comments
Most helpful comment
Hey @Zales0123 , this should be in CoreBundle ?
<service id="sylius.registry.tax_calculation_strategy" class="Sylius\Component\Registry\PrioritizedServiceRegistry"> <argument>%sylius.tax_calculation_strategy.interface%</argument> <argument>Tax calculation strategy</argument> </service>