Sylius: Allow default currency to be defined in the parameters or in an argument

Created on 14 Jun 2019  路  6Comments  路  Source: Sylius/Sylius

Hello :wave:

At the moment, the default currency is USD and is defined in this file which means it is mandatory to answer the currency question in the setup to have another currency set as default.

I think there should be another way to set it, either via a currency key in the parameters, the same way as the default locale is handled, or via an argument in the setup comment.

Thanks

DX RFC

Most helpful comment

Hello @remyvanlerberghe, It seems like a good idea, can speed up setting a simple store with no interaction mode in simple cases. I leave it open for the discussion though, as I would like to see other opinions (cc @Sylius/core-team)

All 6 comments

Hello @remyvanlerberghe, It seems like a good idea, can speed up setting a simple store with no interaction mode in simple cases. I leave it open for the discussion though, as I would like to see other opinions (cc @Sylius/core-team)

I can take care of the PR when it is decided on your side

@Zales0123 Any updates on this subject ? Should I propose a PR ?

Sorry for the long response time, feel free to open a PR with your proposition :)

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

I close the issue as this has been implemented in #10707

Was this page helpful?
0 / 5 - 0 ratings

Related issues

CoderMaggie picture CoderMaggie  路  26Comments

stiffroy picture stiffroy  路  21Comments

tautelis picture tautelis  路  21Comments

madc picture madc  路  24Comments

Gounlaf picture Gounlaf  路  19Comments