Sylius: Updating taxon position not work properly

[bigboss86]

Sylius version affected: 1.3.3

Description
Using leaf nodes up and down not position the taxon correctly

Steps to reproduce
Create taxons and use the leaf nodes.

Possible Solution
Not investigated yet.

[pamil]

Thank you for the bug report! We'll investigate more into that, it would be a great help if anyone would like to try to solve this one.

[smashou]

I think it's because the position field for the taxon is not set properly. When you want to move the leaf nodes it just increment or decrement the position 1 by 1. But sometimes you can have taxon position like this one:

- taxon_1 (parent_id NULL, position 12)
--- taxon_1.1 (parent_id taxon_1, position 2)
--  taxon_1.2 (parent_id taxon_1, position 3)
--  taxon_1.3 (parent_id taxon_1, position 8)

So if you push the up arrow for the taxon_1.3 the position will be decremented by 1 and it will be = position 7. But it's not enough for it to go above the taxon_1.2.

I hope it's clear enough to help you.

[bigboss86]

Hi @smashou. Thanks for your reply.
In the example of Sylius demo, when i do click in arrow up in Books taxon, this move it to bottom of the list. so, i think don't work properly as you says. Maybe the position of taxons in Sylius is wrong too?

[XaBe20]

Hi,

I have exactly the same issue on 1.3.5 / 1.3.6 / 1.3.7 version of Sylius.

[XaBe20]

Hello, One month after, there is news of this issue? thks

[jacquesbh]

This issue is on 1.6.0 as well.
It should not be possible to move Men up, and obviously seeing it going down is not expected :p.

[stale[bot]]

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

[jacquesbh]

Do not stale?

[stale[bot]]

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

[jacquesbh]

Do not stale

[igormukhingmailcom]

The solution:

• Create sylius_admin_ajax_taxon_move_up and sylius_admin_ajax_taxon_move_down actions rather than sylius_admin_ajax_taxon_move
• We shouldn't send position as that an break things, so taxonMoveUp / taxonMoveDown / TaxonPositionType should be removed
• sylius_admin_ajax_taxon_move_up should switch positions between current taxon and taxon with max position (but less than current taxon's position) with same parent as current taxon
• sylius_admin_ajax_taxon_move_down should switch positions between current taxon and taxon with min position (but greater than current taxon's position) with same parent as current taxon

[igormukhingmailcom]

@pamil , could you take a look into #11905 please?

[igormukhingmailcom]

@AdamKasp , this issue seems like fixed by #11905