Sylius: Unused FriendsOfBehat Page Object Extension

Created on 30 Oct 2018  路  3Comments  路  Source: Sylius/Sylius

Sylius version affected: at least 1.3.2

Description

This extension is on dev dependencies but it's not used. Page, PageInterface and UnexpectedPageExtension still be on sylius and same objects from the behat extension are not used yet.

Steps to reproduce

Possible Solution

Remove duplicated objects on sylius and use this behat extension objects :)

Moreover, on sylius, there's more "phpdoc" on these objects, I think it has to be improved on the extension objects.

Behat

Most helpful comment

It's solved since merging #9887, thank you, Lo茂c, one more time 馃帀

All 3 comments

Totally agreed, we should use the extension, it was one of the reasons to extract it 馃憤

I've made a pull request on behat extension to extract phpdoc from sylius duplicated objects
https://github.com/FriendsOfBehat/PageObjectExtension/pull/6

It's solved since merging #9887, thank you, Lo茂c, one more time 馃帀

Was this page helpful?
0 / 5 - 0 ratings

Related issues

mikemix picture mikemix  路  3Comments

inssein picture inssein  路  3Comments

xleliberty picture xleliberty  路  3Comments

tchapi picture tchapi  路  3Comments

igormukhingmailcom picture igormukhingmailcom  路  3Comments