Sylius: [Review] Why title is required ?

Created on 16 Jun 2017  ·  7Comments  ·  Source: Sylius/Sylius

On many websites, you can rate something without comment it.
On Review model, comment is nullable but title is not, it's weird. On few projects, I use review bundle in this use case and I needed to work around.

What do you think ?

RFC

Most helpful comment

@pjedrzejewski @Zales0123
I think i can work on it soon.

All 7 comments

I think we could make it nullable, it is always easier to add NotBlank, than to remove it. :)

@Sylius/core-team Thoughts? @Zales0123.

Totally agreed 👍 After all, even a lonely rating is a valid review for the product and it's the only field that should be required.

@pjedrzejewski @Zales0123
I think i can work on it soon.

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

@pjedrzejewski @pamil Now I think I could work on this soon :) sorry for the delay.

Awesome, thanks! No worries :)

Was this page helpful?
0 / 5 - 0 ratings

Related issues

eb22fbb4 picture eb22fbb4  ·  3Comments

crbelaus picture crbelaus  ·  3Comments

stefandoorn picture stefandoorn  ·  3Comments

ping86 picture ping86  ·  3Comments

stefandoorn picture stefandoorn  ·  3Comments