Sylius: enable_short_alias: false with JMS Serializer

[emodric]

Are there any issues with setting enable_short_alias option to false in JMS Serializer?

When enabled, this option aliases @serializer service to @jms_serializer.serializer, but the interfaces are not compatible between each other, so our custom app which uses @serializer crashes, since the incompatible implementation is being injected into our classes.

If Sylius does not depend on enable_short_alias: true, how would you feel about a pull request setting it to false by default?

[pjedrzejewski]

@lchrusciel Do you know anything about this option?

[lchrusciel]

We could open a PR with RFC and ask others to vote. It is fine for me, especially because we don't even touch serializer itself. AFAIK we are not using JMS Serializer anywhere directly, only through FOSRestBundle so if everything will work, we can merge it.

Also, we should probably point it out in our docs.

[emodric]

@lchrusciel Do you want me to open a PR or should you?

[lchrusciel]

I would really appreciate it :)

[emodric]

@lchrusciel Done in #8186

[lchrusciel]

Lets wait a few days and we will probably merge it :)