Sylius: [UiBundle] display overflow on paginator with too many pages (v1.0.0-alpha1)
I have a display problem on a paginator with too many pages.
Have you plan to improve it ?
loic425
All 13 comments
@pjedrzejewski @michalmarcinkowski I think it could be great to contribute on pagerfanta to purpose a SemanticUiTemplate extending Pagerfanta\View\Template.
Maybe, I would work on it soon...
loic425
on 16 Nov 2016
@pjedrzejewski @michalmarcinkowski
I started working on SemanticUiTemplate
The second step is to submit a pull-request on pagerfanta and whiteoctober pagerfanta. So tell me first if this could be ok for you.
loic425
on 16 Nov 2016
Looks good to me!
michalmarcinkowski
on 17 Nov 2016
Looks great, @loic425 Please submit the PR, hopefully it will get merged in time to use it in Sylius, nice work! :)
pjedrzejewski
on 17 Nov 2016
@michalmarcinkowski @pjedrzejewski
Ok, i'll do that today. If the pagerfanta merge is too long, it's possible to add SemanticUiTemplate and SemanticUiView in sylius Ui component and SemanticUiTranslatedView in SyliusUiBundle in waiting for pagerfanta merge and remove them later.
loic425
on 17 Nov 2016
@loic425 Agreed, please post the PR here when it is open - I will help with speeding up the merge (by being a bit annoying, as we are short on time :D).
pjedrzejewski
on 17 Nov 2016
@pjedrzejewski
PR on Pagerfanta
PR on PagerfantaBundle
loic425
on 17 Nov 2016
@pjedrzejewski
@michalmarcinkowski
We have no news from White October team... Do you want to wait a little or make a copy into Sylius Ui Component and SyliusUiBundle ?
loic425
on 21 Nov 2016
@loic425 I tweeted - https://twitter.com/pjedrzejewski/status/800664021938606080. Let's wait 1-2 days and if still nothing, then we should add it to SyliusUiBundle. :)
pjedrzejewski
on 21 Nov 2016
@pjedrzejewski
No news, so i'm gonna do a sylius pull-request :)
loic425
on 24 Nov 2016
@pjedrzejewski
There's an answer from whiteoctober :) yes !
loic425
on 24 Nov 2016
@loic425 do you think it will be possible to get it merged tomorrow?
michalmarcinkowski
on 29 Nov 2016
@michalmarcinkowski
Yep, i think it's possible if i copy all the files on sylius in waiting for pagerfanta new release.
loic425
on 29 Nov 2016
Related issues
stefandoorn
路
3Comments
javiereguiluz
路
3Comments
xleliberty
路
3Comments
mezoni
路
3Comments
igormukhingmailcom
路
3Comments
Most helpful comment
@pjedrzejewski @michalmarcinkowski
I started working on SemanticUiTemplate
The second step is to submit a pull-request on pagerfanta and whiteoctober pagerfanta. So tell me first if this could be ok for you.