Sway: Fullscreen improvements

Created on 20 Apr 2018  路  22Comments  路  Source: swaywm/sway

  • [x] Containers need to be fullscreenable.
  • [ ] Surfaces can request to be fullscreened on a specific output, which is currently ignored (#1813).
  • [x] Moving a fullscreen view to another workspace unfullscreens it.
  • [x] Unmanaged xwayland surfaces need to be rendered if the fullscreen view is xwayland (eg. Chromium context menu).

Most helpful comment

Would it be possible to add a separate "fully maximized" mode which looks
like fullscreen but has transparency

All 22 comments

Also, when using xwayland app (chromium) in full screen context menu doesn't show up.

Yeah, that's because unmanaged xwayland surfaces need to be rendered if the fullscreen view is xwayland.

@RyanDwyer I think it is worth adding that to the list.

I think blanking background needs to be moved to wlroots, since with direct scanout you can't avoid doing it.

I disagree. We're going to give the user the tools to deal with direct scan-out themselves.

It's already in wlroots if you use wlr_output_set_full screen_surface. And yes, it should be there.

For the record, I'm not happy with wlr_output_set_fullscreen_surface

It seems you're not happy with direct scan-out too.

ding ding ding

But fwiw I'm on board with making wlroots support it, but like everything else we need to do it in an unopinionated way.

Agreed.

The wallpaper should still be rendered in fullscreen for transparent applications.

The wallpaper should still be rendered in fullscreen for transparent applications.

No. Won't work with direct scan-out.

Yes it wiiiiiill

A setting was agreed on to toggle that.

fullscreen flipping is still not synchronized (e.g. it can tear), right? This ought to be added.
Also fullscreen mode doesn't yet stop the frame callback for all invisible surfaces below.

fullscreen flipping is still not synchronized (e.g. it can tear), right?

No, it is synchronized, it can't tear.

Also fullscreen mode doesn't yet stop the frame callback for all invisible surfaces below.

It should and used to, probably a bug.

Closing this because the last remaining item has a specific issue for it (#1813).

The wallpaper should still be rendered in fullscreen for transparent applications.

A setting was agreed on to toggle that.

But i can't seem to find it. Or was it just agreed on and not implemented?

It's not been implemented.

The wallpaper is still not rendered for fullscreen transparent applications.

The wallpaper is still not rendered for fullscreen transparent applications.

The xdg-shell protocol states that fullscreen windows should be rendered over a solid black background. Rendering the wallpaper would be a violation of the specification, which is why this has not been implemented

Would it be possible to add a separate "fully maximized" mode which looks
like fullscreen but has transparency

Was this page helpful?
0 / 5 - 0 ratings

Related issues

marcoms picture marcoms  路  3Comments

soymjolk picture soymjolk  路  3Comments

ddevault picture ddevault  路  4Comments

Olie440 picture Olie440  路  4Comments

WhyNotHugo picture WhyNotHugo  路  3Comments