Suitecrm: 7.9 Upgrade fails if SuiteP is disabled, and breaks instance

[pgorod]

This is from a couple of issues in the forums, like this one. Thanks to user LISpeedyG.

Issue

Some people have disabled SuiteP theme in their instances, so that their users couldn't select the new theme. Sometimes this was a necessity because of theme-specific customizations, other times it was a matter of taste.

This seems to be possible with one of these ways (or both?):

In config.php something like this:

  'disabled_themes' => 'SuiteP,Suite7',

In config_override.php something like this:

 $sugar_config['disabled_themes'] = 'SuiteP,Suite7';

Expected Behavior

SuiteCRM should re-enable the SuiteP theme and complete the upgrade successfully; or at the very least, give a proper error message asking the admin to go and enable the theme.

Actual Behavior

The upgrade is interrupted at the last stage of the Wizard, no error shown.

SuiteCRM is now broken, doesn't work at all, and it's hard to diagnose. Nothing relevant in the logs.

Steps to Reproduce

1. Get a working 7.8 instance and disable the SuiteP theme in config.php or config_override.php
2. Try the upgrade to 7.9

Context

This is not easy to diagnose. It is not very serious for people who have a way to go back (backups, VM snapshots) but is highly critical for people who don't. On the other hand, it shouldn't be _that_ common.

Your Environment

• SuiteCRM Version used: 7.8 upgrading to 7.9

[pgorod]

I was able to see this in another instance on the Spanish forums, and then reproduced it in my system. It seems there _is_ a message in php_errors.log (coming from a sugar_die in another place in the code),

No valid themes are found on this instance in /var/www/html/include/utils.php:1687

but the person on the forums wasn't able to see that log, as sometimes it happens on some servers :-(

So at least a message in suitecrm.log will guide in the correct direction. And it makes sense to log it there.