Time for a new release... Tesseract dictionary download don't work for old version + much new stuff :)
I think the "Multiple replace", "Scene changes" + new sub formats are more than just a patch...
TODO:
- [x] General testing + (fixing bugs)
- [x] Test compare
- [x] Test "Binary image compare OCR"
- [x] Test "Multiple replace"
- [x] Test "Scene changes"
If you know any issue that should be included then do let us know :)
niksedk
All 36 comments
Can you decide on this?
aaaxx
on 4 Oct 2016
@aaaxx: ok, removed prompt.
What about showing videoplayer + waveform default for new users?
niksedk
on 4 Oct 2016
Some minor fixes for ExportPngXml: https://github.com/SubtitleEdit/subtitleedit/pull/1992
ivandrofly
on 7 Oct 2016
Compare is still somewhat buggy...
niksedk
on 8 Oct 2016
Compare is still somewhat buggy...
Did you find something?
ivandrofly
on 8 Oct 2016
Show only differences... if I delete first line in a subtitle.
niksedk
on 8 Oct 2016
Does it throw or something...?
ivandrofly
on 8 Oct 2016
It works :)
I was comparing the "compare function" to 3.4.12 which only showed differences in text when starting compare which seems like what we want most of the time, right?
niksedk
on 8 Oct 2016
Fixed a few issues in fb5c619fcd7a1d5cd1c4ed905d791e7786550888 - extra lines were hidden when showing only changes (regression) + deleted lines (or new) are not shown correct (with red empty line) if next line has same duration (old bug) + coloring in listview2 more consistent (old bug).
@ivandrofly: Does it look/work okay ?
niksedk
on 8 Oct 2016
Looks good :); I have made some minor changes: https://github.com/SubtitleEdit/subtitleedit/pull/1995
ivandrofly
on 9 Oct 2016
Only found a renaming bug in the "Multiple replace"... a8febaca51a9ab9df464c311442327add61cccfa
niksedk
on 9 Oct 2016
Perhaps, it is useful to add in the "Multiple replace" the ability to remember window position? Because after you close the program window position is reset.
Elheym
on 9 Oct 2016
Sometimes shows not the whole text. In Russian language.
Elheym
on 9 Oct 2016
Why are we trimming the lines when Comparing (we wanna see the difference right)?
Subrip will trim end when loading, should it be done by FCE?
[Subrip]
If you have subtitle like:
1
00:00:01,000 --> 00:00:03,000
<whitespace>foobar.<whitespace>
after loading it becomes:
1
00:00:01,000 --> 00:00:03,000
<whitespace>foobar.
- [x] Fix for Subrip: #1997
_PS: Please do not release yet, I've got some patches on their ways._
ivandrofly
on 9 Oct 2016
@Elheym: Sorry, I can move something a few pixels... but I think you have to shorten the texts.
niksedk
on 10 Oct 2016
@niksedk: Fixed. #2001
Elheym
on 10 Oct 2016
@Elheym: thx :)
Besides the fixed bug in compare regarding save/load settings (87191e699b73dc32ccdbd8df3739de68fa379def), compare still has problems - show only differences is still buggy e.g. when inserting a new line (works in old version)
niksedk
on 13 Oct 2016
How did you produce the bug? (by inserting new line while in Main/Listview and compare it with current subtitle)?
ivandrofly
on 13 Oct 2016
Please also insert this as well in the next version, should be more or less easy to do:
https://github.com/SubtitleEdit/subtitleedit/issues/2017
Thanks, you're amazing! 馃憤
MaximPro
on 17 Oct 2016
Can you please merge #1952 for this release, so this program can be more intuitive?
diomed
on 17 Oct 2016
Bug
If you try to download portuguese portugal dictionary from (SpellCheck) it will throw exception.
Fixed
ivandrofly
on 18 Oct 2016
Nice find about the spell check dictionary :)
niksedk
on 18 Oct 2016
Compare fix here: https://github.com/SubtitleEdit/subtitleedit/commit/dbb267513086784dd43f9cf03a8af467031c4b34
Portuguese dictionary fix here: https://github.com/SubtitleEdit/subtitleedit/commit/953d07589d4fcc5e83f04e192670f790b6eb5b9c
Hopefully close now...
niksedk
on 18 Oct 2016
Great Stuff Niksedk, you're a hero for the sczene 馃憤 :)
When you will release a new beta maybe - we help you to check on more errors and stuff in Version 3.5.
I had some guy lately who could not open videos, so I told him to install the codecpack from codecguide.com, maybe you should give a hint or something, if it doesn't work to open a video.
MaximPro
on 18 Oct 2016
Latest (and probably last) beta: https://github.com/SubtitleEdit/subtitleedit/releases/download/3.4.13/SubtitleEditBeta.zip (portable version)
niksedk
on 19 Oct 2016
ivandrofly
on 21 Oct 2016
Thx for the updates :)
Sorry, don't have too much time... but another last beta is up: https://github.com/SubtitleEdit/subtitleedit/releases/download/3.4.13/SubtitleEditBeta.zip
Trying to improve #2016
niksedk
on 23 Oct 2016
@ivandrofly: It looks like MacSub format is freezing SE... could you take a look (just pick any random text file)
niksedk
on 24 Oct 2016
Patch I sent regarding to numbering subtitle issues in MacSub: https://github.com/SubtitleEdit/subtitleedit/pull/2023/files
@ivandrofly: It looks like MacSub format is freezing SE... could you take a look (just pick any random text file)
Sorry, I don't understand how to produce it... should I drag&drop a random .txt file while MacSubs is selected?
Hmm... I think I found something!
In fact the problem is not only with MacSub, is with "all" subtitle format that are frame-based.
Every time you clicked in a paragraph in *_main list view_ .ToText() will be called.
Edited:
Aah! I already sent patch for this bug like a moth ago (merged and tested):
https://github.com/SubtitleEdit/subtitleedit/pull/1975/files
We need to round when converting from frame to timecode.
Paragraph.cs
c#
public void CalculateTimeCodesFromFrameNumbers(double frameRate)
{
StartTime.TotalMilliseconds = Math.Round(StartFrame * (TimeCode.BaseUnit / frameRate));
EndTime.TotalMilliseconds = Math.Round(EndFrame * (TimeCode.BaseUnit / frameRate));
}
In Main.cs#L6773 where we are checking (last.StartTime.TotalMilliseconds != startTime.TotalMilliseconds) will be true and var showSource will be set to true because we didn't round when converting to TimeCode then ShowSource() will be fired. :)
ivandrofly
on 24 Oct 2016
No, "IsMine" is just very very slow when opening an unknown file...
niksedk
on 24 Oct 2016
No, "IsMine" is just very very slow when opening an unknown file...
I'll take a look.
Please see https://github.com/SubtitleEdit/subtitleedit/issues/1990#issuecomment-255793610.
ivandrofly
on 24 Oct 2016
OK, not all text files freezes MacSub but some do, like this: http://www.nikse.dk/sub.zip
niksedk
on 24 Oct 2016
Several bugs found in UnknownSubtitle41.cs 鈿狅笍
- [x] When serializing to text, end-frame won't be written with a '/' at the end.
- [x] Transcoding from frame to milliseconds.
- [ ] After reading frames using 24.0fr (default), everything will be converted from 24.0 to current frame rate when writing to text.
ivandrofly
on 25 Oct 2016
3.5 is out finally :)
Was a bit tougher than usual... more bugs (especially in compare) and less time I guess.
niksedk
on 26 Oct 2016
Ups, I think you forgot https://github.com/SubtitleEdit/subtitleedit/pull/2023/files, line number will be messed up when loading from a MacSub. 馃槙
ivandrofly
on 26 Oct 2016
Jep, no biggie though. Merged now.
niksedk
on 26 Oct 2016
Related issues
taxen
路
6Comments
m0ck69
路
5Comments
amiremami
路
4Comments
frozenspider
路
5Comments
LeonCheung
路
5Comments
Most helpful comment
Only found a renaming bug in the "Multiple replace"... a8febaca51a9ab9df464c311442327add61cccfa