Stylus: Styles are not applied to background tabs in v1.1.7.6

[monk-time]

• Browser: Firefox 57.0.1
• Operating System: Win7x64

Immediately after updating to v1.1.7.6 I noticed that Stylus stopped applying styles to tabs opened in background. Eve after switching to those tabs styles don't get applied. This should be very easy to reproduce, but in case I'm wrong I am willing to provide all the info I can gather about this issue.

[LeZVince]

I have the same bug since yesterday :(

Firefox 57.0.2 + Windows 8.1

[tophf]

Can't reproduce.

[redking974]

I've got a same issue since I've updated Firefox. The style applies on some tabs, and doesn't apply on other tabs. I only see the recent update of Firefox as origin.

[tophf]

Can't reproduce in 57.0.2, 52.5.2, 59.

[LeZVince]

It's the same bug as Stylish, that's why I moved on Stylus...

[tophf]

If you want this to be fixed you need to provide a detailed description on how to reproduce it. The first thing to try is a clean browser profile with only Stylus extension and nothing else.

[Mottie]

And it would help to know the version of Stylus where this wasn't an issue.

[Shrapnel]

I'm on Nightly, 59.0a1, and I am seeing this as well with 1.1.7.6 only. I've reverted to 1.1.7.4 and this does not occur.

[tophf]

It'd be helpful if someone who experiences the problem would try in a new browser profile with just Stylus extension installed.

[monk-time]

Same system, clean profile (no extensions installed), FF 57.0.2:

1. Install Stylus 1.1.7.6.

2. Create a new style, click Import, paste this mozilla-format style that makes the font on adventofcode.com smaller:

   @-moz-document domain("adventofcode.com") {
   body {
       font-size: 11pt;
   }
   }
   

   (btw, on this step panda-syntax theme doesn't work correctly: if I set this theme and then click "Back to manage", opening any script again shows the code on white background and in wrong font, this is also something that didn't happen before 1.1.7.6)

3. Open https://adventofcode.com/2017/about - the style is applied.

4. On that page middle-click or ctrl+click the About button, this opens the same page in a new background tab.
5. Switch to the opened tab after it has finished loading.
6. The style is not applied, although the extension icon is active and has a badge with "1".

There's nothing in the Browser Console. I'll post a recording and do the same steps in the previous version of Stylus in a few minutes.

[monk-time]

Here's a video of the steps above: https://vimeo.com/246594906

I also couldn't reproduce this issue on 1.1.7.4 in a fresh profile.

[tophf]

@monk-time, thanks, but I can't reproduce.

Anyway, I've updated the master branch with a tentative fix for the problem.

Try the new version by loading it as a temporary extension on about:debugging page (make sure to disable the official Stylus).

P.S. The theme issue is fixed now.

[sirxemic]

I did a git-bisect and it looks like commit 6d4689e559af5cddef805239642803b5c2eff120 is the culprit.

[tophf]

@sirxemic, yeah it was the only significant change but it's not clear why it causes the issues and how to reproduce them. I'd rather find out that instead of blindly reverting it. Can you please try the new master branch? See my comment above.

[monk-time]

@tophf, I removed Stylus 1.1.7.6 from the clean profile, installed the new version (had to unpack it, make a new zip with the contents of the top stylus-master folder and rename the archive to .xpi, wtf mozilla) and repeated same steps: the code editor theme issue is gone now, but I still get the same bug with bg tabs.

[sirxemic]

@tophf Yeah I tried the latest master. It's still happening, though. Simply reverting that commit does the trick for me, but I understand that you prefer not to do that before we've figured out what exactly the root cause is.

[monk-time]

I looked into the inspector (with master.zip installed) and noticed that the rule from the step 2 does appear in a background tab, but it gets overrided by the page's css. If I add !important, bg tabs work fine, but without it the bug reappears:

• body { font-size: 11pt; }, foreground tab, the style is applied:

• body { font-size: 11pt; }, background tab, the style is not applied:

[tophf]

Try the master branch once more. I believe I fixed it. Also, no need to make an xpi: simply point to manifest.json on about:debugging

[sirxemic]

Yes! It works :)

[monk-time]

@tophf Thanks for the tip! And yes, can confirm the latest master fixes the issue. 👍

[tophf]

AMO has the updated version now.

[redking974]

Yes, it fixes it. Thanks !