Styled-components-website: Add "Why am I getting attribute warnings?" to the FAQ
Basically, my answer in this issue https://github.com/styled-components/styled-components/issues/1198#issuecomment-336628848 needs to be cleaned up and put into our FAQ!
mxstbr
All 5 comments
@mxstbr Should we just explain it over react-router just like you did in that issue or make it more generalized?
morajabi
on 26 Oct 2017
More generalised I think?
mxstbr
on 26 Oct 2017
Yea and then we can take react router as an example since it's the most common cause of this confusion.
morajabi
on 26 Oct 2017
I submitted a PR for adding this documentation. I peeped the RR source for Link (https://github.com/ReactTraining/react-router/blob/master/packages/react-router-dom/modules/Link.js#L75) and it is as @mxstbr described. I kept his explanation but adjusted the examples slightly to provide a bit more detail.
I think there are many instances where this can happen aside from RR. People will probably run into this as they're building integration tests so I took a more generalized explanation but kept the "Link" example.
rodocite
on 6 Mar 2018
Thank you @rodocite!
mxstbr
on 8 Mar 2018
Related issues
mxstbr
路
4Comments
johannesnagl
路
4Comments
kitten
路
6Comments
kitten
路
7Comments
mxstbr
路
4Comments
Most helpful comment
I submitted a PR for adding this documentation. I peeped the RR source for Link (https://github.com/ReactTraining/react-router/blob/master/packages/react-router-dom/modules/Link.js#L75) and it is as @mxstbr described. I kept his explanation but adjusted the examples slightly to provide a bit more detail.
I think there are many instances where this can happen aside from RR. People will probably run into this as they're building integration tests so I took a more generalized explanation but kept the "Link" example.