Styled-components-website: Upgrade next to version 3 as soon as 3.0.7 is released

Created on 29 Aug 2017  Â·  7Comments  Â·  Source: styled-components/styled-components-website

Currently we have a vendored version of next: https://github.com/styled-components/styled-components-website/blob/master/vendor/next-v2.4.8.tgz

This is to work around our styling problem that prevented us from wrapping the entire app. A fix was proposed here but wasn't merged for a long time: https://github.com/zeit/next.js/pull/2010

Now that it was merged we can get rid of the vendored version and upgrade to v3, as soon as the fix lands in the next patch release

bug

Most helpful comment

Guys, [email protected] is with the change you guys are looking for.

All 7 comments

Except I couldn't get it to work: https://github.com/zeit/next.js/pull/2831

@mxstbr that explains why we end up with duplicated rules on the client... oops, I forgot about it running on the client as well. we can keep it as is, but update it once we find a workaround?

Let's just try and find a workaround? :laughing: We're going to need to put it in the Next docs anyway asap so not more people ship with an unnecessarily slow setup.

Guys, [email protected] is with the change you guys are looking for.

@philpl what do you think of making this change? Next 3.2.2 is out :–)

PS: I'm asking because I'm starting with Next.js and would like to see a nice up-to-date example of styled-components with it. Have been using your module with CRA and even react-boilerplate for a while, but now it's time for some SSR!

UPD: Just saw https://github.com/zeit/next.js/pull/2945 :open_mouth: :wink:

@kachkaev you can give it a shot! We would love that 🙌

Closing, as there's work in progress to get up to next 5: #232

Was this page helpful?
0 / 5 - 0 ratings

Related issues

mxstbr picture mxstbr  Â·  6Comments

mxstbr picture mxstbr  Â·  4Comments

x3388638 picture x3388638  Â·  5Comments

markatk picture markatk  Â·  5Comments

el1f picture el1f  Â·  4Comments