Streetmerchant: MAX_PRICE_SERIES_SONYPS5C & SONYPS5DE filters do not work properly

[gigi2006]

I have entered the price of 600 and 500 for MAX_PRICE_SERIES_SONYPS5C & SONYPS5DE.
however i get warehouse deals in the amount of 1200 and 1300....

maybe it's because of the warehouse?

is by the way at Amazon.DE

MAX_PRICE_SERIES_SONYPS5C="600"
MAX_PRICE_SERIES_SONYPS5DE="500"

I just saw that the colleague at #913 has a similar problem and has also somehow solved.

would be great if someone could also implement for all of us :)

[neatchee]

• Please attach the screenshot that streetmerchant saves when it detects an item in-stock (automatically saved to the streetmerchant directory)
• Please provide a URL for the page that is causing the false positive for you

[gigi2006]

so i don't know now how the whole thing should be occupied with a screenshot and a link, because it is currently no longer online, but ok :)

@neatchee @jef

my dotenv
MAX_PRICE_SERIES_SONYPS5C=600
MAX_PRICE_SERIES_SONYPS5DE=500

Digital Alert Link
https://www.amazon.de/gp/offer-listing/B08H98GVK8

Disk Alert Link
https://www.amazon.de/gp/offer-listing/B08H93ZRK9

[neatchee]

Those are not proper store listings, which is why this is breaking.
Did you add the selector for this yourself? The entries I see in the amazon-de.ts definitions do not include these URLs.

Specifically, these are "digital notification" pages, NOT product listings. So the selector cannot find the price and defaults to just showing it as in-stock when the button shows up.

[gigi2006]

thank you for your help. no, I didn't add anything, everything is definitely as original as it was.

@neatchee

The reason why you don't see it in amazon.de is because it can be found in amazon.de.warehouse, I just looked it up myself because I was also surprised.

[neatchee]

Do you have a link to that page in amazon.de.warehouse?

[gigi2006]

Do you have a link to that page in amazon.de.warehouse?

Off course
https://github.com/jef/streetmerchant/blob/main/src/store/model/amazon-de-warehouse.ts

[neatchee]

Sorry I mean the actual listing on Amazon's website. The URL in that file
does not match the image in your screenshot

On Fri, Dec 25, 2020, 1:42 AM gigi2006 [e-mail] wrote:

Do you have a link to that page in amazon.de.warehouse?

Off course

https://github.com/jef/streetmerchant/blob/main/src/store/model/amazon-de-warehouse.ts

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jef/streetmerchant/issues/1500#issuecomment-751221786,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABA3WHZJWWPG7LWGQRJKS4TSWRNBXANCNFSM4VGER2VQ
.

[gigi2006]

Sorry I mean the actual listing on Amazon's website. The URL in that file does not match the image in your screenshot
…
On Fri, Dec 25, 2020, 1:42 AM gigi2006 @.*> wrote: Do you have a link to that page in amazon.de.warehouse? Off course https://github.com/jef/streetmerchant/blob/main/src/store/model/amazon-de-warehouse.ts — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1500 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABA3WHZJWWPG7LWGQRJKS4TSWRNBXANCNFSM4VGER2VQ .

Unfortunately there are currently no items to be seen in the warehouse. So the link is right, only there is nothing right now. the difficult thing is that even if what comes in it is gone within a very short time.

//Edit:
should I look for another warehouse deal where items are available so you can compare?

[neatchee]

If you can track down another listing that shows that page format that
would work too. Doesn't have to be the exact product. Just enough for us to
find a unique page element for clarifying the page as equivalent to "out of
stock"

On Fri, Dec 25, 2020, 3:24 AM gigi2006 [e-mail] wrote:

Sorry I mean the actual listing on Amazon's website. The URL in that file
does not match the image in your screenshot
… <#m_-3409304791890230154_>
On Fri, Dec 25, 2020, 1:42 AM gigi2006 @.*> wrote: Do you have a link
to that page in amazon.de.warehouse? Off course
https://github.com/jef/streetmerchant/blob/main/src/store/model/amazon-de-warehouse.ts
— You are receiving this because you were mentioned. Reply to this email
directly, view it on GitHub <#1500 (comment)
https://github.com/jef/streetmerchant/issues/1500#issuecomment-751221786>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABA3WHZJWWPG7LWGQRJKS4TSWRNBXANCNFSM4VGER2VQ
.

Unfortunately there are currently no items to be seen in the warehouse. So
the link is right, only there is nothing right now. the difficult thing is
that even if what comes in it is gone within a very short time.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jef/streetmerchant/issues/1500#issuecomment-751235510,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABA3WH5G7JDAMICCLH5H3EDSWRY7TANCNFSM4VGER2VQ
.

[gigi2006]

ok no problem, so here's the deal.

have you now picked out an ASIN that has both just yet. a used and a new directly from Amazon.
so everything should be present in the example I think what you need, right?

https://www.amazon.de/gp/offer-listing/
+
B07FVS6LVK

https://www.amazon.de/gp/offer-listing/B07FVS6LVK

Example:
the actual link is this one: https://www.amazon.de/gp/offer-listing/HERECOMETHEASINOFANYPRODUCT
then search for any product, copy the ASIN there and paste it in the back, like for example here: https://www.amazon.de/gp/offer-listing/B07FVS6LVK

If you can track down another listing that shows that page format that would work too. Doesn't have to be the exact product. Just enough for us to find a unique page element for clarifying the page as equivalent to "out of stock"
…
On Fri, Dec 25, 2020, 3:24 AM gigi2006 @.> wrote: Sorry I mean the actual listing on Amazon's website. The URL in that file does not match the image in your screenshot … <#m_-3409304791890230154_> On Fri, Dec 25, 2020, 1:42 AM gigi2006 *@.*> wrote: Do you have a link to that page in amazon.de.warehouse? Off course https://github.com/jef/streetmerchant/blob/main/src/store/model/amazon-de-warehouse.ts — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1500 (comment) <#1500 (comment)>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABA3WHZJWWPG7LWGQRJKS4TSWRNBXANCNFSM4VGER2VQ . Unfortunately there are currently no items to be seen in the warehouse. So the link is right, only there is nothing right now. the difficult thing is that even if what comes in it is gone within a very short time. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1500 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABA3WH5G7JDAMICCLH5H3EDSWRY7TANCNFSM4VGER2VQ .

[neatchee]

Yes, this gives us what we need.

So, I think the way we will handle this is by treating all pages of this format as "out of stock" for now to fix this bug. You can also create a new issue to request that "new" products on pages like this be recognized as valid and price-checked, but that would be significantly more work, and would be a "feature request" rather than a bug :)

[gigi2006]

Yes, this gives us what we need.

So, I think the way we will handle this is by treating all pages of this format as "out of stock" for now to fix this bug. You can also create a new issue to request that "new" products on pages like this be recognized as valid and price-checked, but that would be significantly more work, and would be a "feature request" rather than a bug :)

are you sure? because I mean what's this amazon-de-warehouse.ts for? I just mean that the price check doesn't work here, otherwise everything will fit.

[neatchee]

No, you're right. I was looking at the wrong .ts file hahah.

This should be easy enough to fix. The price selector is just broken. Fix incoming.