Store: 🐞[BUG]: Cannot assign @Select to private property

[splincode]

please create stackblitz or guthub repo with reproduce

[twjacobsen]

There is a link under "Minimal reproduction"... IDK why it won't make it an actual link..

[markwhitfeld]

@splincode I believe that this would have been caused by the extra typings you added in this commit:
https://github.com/ngxs/store/commit/ca7de82b3032057743dbd1cb4e50a5cf934011d1#diff-f51f5a2731644ac6eec21012cd378ad6R14
Are you able to improve the types to handle private fields?

[splincode]

Sorry, I read the description poorly and did not look at the link

[splincode]

Sorry, I read the description poorly and did not look at the link.

@markwhitfeld I will investigate

[steve-todorov]

I'm getting this issue as well. In our case we have an AbstractAuthorityGuard which has a "default" implementation of CanActivate and allows for other Guards to extend the abstract class and do minor additional checks. Sort of like this oversimplified example:

@Injectable({
    providedIn: 'root'
})
export abstract class AbstractAuthorityGuard implements CanActivate {
    @Select(SessionState.authorities)
    protected authorities$: Observable<UserAuthority[]>;

    canActivate(): Observable<boolean> {
        return this.authorities$;
    }
}

This is happening after upgrading to Angular 9, TypeScript 3.7.5 and @ngxs/[email protected].

[steve-todorov]

Hey guys, any update on this? :)

[splincode]

While this is a difficult time, I will get to this problem soon

I have now completely concentrated my efforts on a new plugin that will improve working with states:
https://github.com/ngxs-labs/data

[steve-todorov]

Thanks for the update! ngxs-labs/data looks very promising! Is there a release planned for the near future?

[splincode]

It is planned to implement a lot of functionality yet, but I hope to make a release at the end of this month

[bschantz]

Any update? I've got a large codebase that I'd like to upgrade to Angular 9, but this issue is blocking.

[markwhitfeld]

It looks like @splincode is working on this in PR #1623. Hope to get this fix into the next release!

[steve-todorov]

It looks like you guys have merged the PR already. Is there anything more that needs to be done for this to get released? :)

Off-topic: How are things going with ngxs-labs/data?

[markwhitfeld]

Good news this has been addressed in NGXS v3.7, released last week.
( see https://dev.to/ngxs/announcing-ngxs-3-7-1kbk for release notes )

I will close this issue. Please let us know if it is not resolved.

[steve-todorov]

Awesome news! Thanks! :)