Stk-code: [UX] When you fail a challenge, the selection defaults to "Return to map" instead of "Restart"

[kryptot7]

Defaulting to restart makes more sense, because if you accidentally press it instead of "Go back", there's no load times and you can just press return to map from the pause menu. Also, it encourages players to try, try again (which is likely what they want to do anyway).

[Benau]

could be fixed by
middle->setFocusForPlayer(PLAYER_ID_GAME_MASTER); instead of bottom ~220 result screen cpp

auria do you really care?

[auriamg]

@Benau sure, it's easy and makes sense

[psypherium]

The opposite issue is also present. When you succeed a challenge, the selection defaults to "restart" instead of "return to map" Should I have made a new issue for this instead of commenting to a closed issue? I thought it was just too similar to warrant a new issue post.

[auriamg]

@psypherium I cannot reproduce this issue on latest git, the correct button is highlighted by default for me

besides, when you succeed a challenge, there is no "restart" button

[psypherium]

Rebuilt and tested again, I realise what is happening now, If you succeed the same challenge a second time, the restart option comes back and becomes the default.