Status-react: Disable search bar on empty chat state and fix pull-to-refresh gesture

Created on 4 Dec 2019  Â·  21Comments  Â·  Source: status-im/status-react

Problem

  1. The current implementation of the searchbar only includes searching the local chat list. When the list is empty, there are no items to search. In context of the empty state screen the search bar can easily be misinterpreted as a way to 'search for public channels'. See image below.

Screenshot_20191204-095055_Status

  1. Additionally, when you pull to refresh, the search bar appears and then disappears immediately, so it can not be used. See gif.

Implementation

Disable pull to show Search bar on empty state of chat.
Fix search bar appearance when pulling to refresh screen.

Acceptance Criteria

Pulling down on the empty state screen of chat does not show the search bar.

UUX improvements chat core

Most helpful comment

Hello, I am ready to start working on an issue. I will write if I have questions.

All 21 comments

cc @errorists @rachelhamlin

Great point. Mind if I bounty this?

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


__This issue now has a funding of 75.0 DAI (75.0 USD @ $1.0/DAI) attached to it.__

Issue Status: 1. Open 2. Cancelled


__Work has been started__.

These users each claimed they can complete the work by 5 months ago.
Please review their action plans below:

1) ognian7 has been approved to start work.

  1. Implement the check for the empty list and Disable pull to show Search bar on empty state of chat.
  2. I will fix the search bar appearance when pulling to refresh screen.
  3. Create tests
    2) loganbek has applied to start work _(Funders only: approve worker | reject worker)_.

I will remove the search bar on empty chat state and fix the search bar on pull gesture.

Learn more on the Gitcoin Issue Details page.

Welcome @ognian7! I'm approving you on a first come first serve basis, but your plan sounds good as well. Here's our quick start: https://status.im/build_status/status_react_quickstart.html

Let us know if you have any questions.

@ognian7 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] reminder (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@ognian7 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] reminder (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@ognian7 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] reminder (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Hello, I am ready to start working on an issue. I will write if I have questions.

@ognian7 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] reminder (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@ognian7 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] reminder (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


@ognian7 due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • [x] reminder (3 days)
  • [x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


@ognian7 due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • [x] reminder (3 days)
  • [x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

I would need some more time, I will work during the holidays, thank you

@ognian7 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] reminder (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@ognian7 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] reminder (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


@ognian7 due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • [x] reminder (3 days)
  • [x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


@ognian7 due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • [x] reminder (3 days)
  • [x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Issue Status: 1. Open 2. Cancelled


__The funding of 75.0 DAI (75.0 USD @ $1.0/DAI) attached to this issue has been cancelled by the bounty submitter__

Was this page helpful?
0 / 5 - 0 ratings

Related issues

flexsurfer picture flexsurfer  Â·  57Comments

jeluard picture jeluard  Â·  45Comments

churik picture churik  Â·  52Comments

jakubgs picture jakubgs  Â·  44Comments

pedropombeiro picture pedropombeiro  Â·  63Comments