Status-react: Support for multicollateral DAI

Created on 19 Nov 2019  路  10Comments  路  Source: status-im/status-react

Problem

Multi-collateral DAI launched on November 18th. Changes to the DAI token are required to support this shift.

Implementation

  • The current DAI token is now 'single collateral DAI' and should be renamed to SAI.
  • In addition to SAI, we should add the new DAI to our hardcoded token list.
  • The address for multi-collateral DAI is 0x6b175474e89094c44da98b954eedeac495271d0f
  • The image assets are found HERE

Acceptance Criteria

Status default assets list should include both DAI and SAI with the appropriate addresses & logo images.

Other wallets are representing DAI and SAI like so:
image

Notes

chore wallet

Most helpful comment

I am willing, always for the mysterious StatusSceptre! :)

All 10 comments

Could I pick this one up?

@acolytec3 yes please! It's a very small one (~50USD) and funded in ETH rather than DAI as I migrated our funds, but Gitcoin still supports only SAI :)

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


__This issue now has a funding of 0.287 ETH (49.95 USD @ $174.05/ETH) attached to it.__

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


__Work has been started__.

These users each claimed they can complete the work by 4聽weeks from now.
Please review their action plans below:

1) acolytec3 has started work.

Will complete task according to the requirements

Learn more on the Gitcoin Issue Details page.

@StatusSceptre Thanks! Got a PR going locally. Who normally creates the assets in the 1x/2x/3x PNG sizes? I took a first pass at it using GIMP and just took the DAI.png from the Maker Assets and shrunk it to 120, 80, and then 40 px across like all the other token PNGs. Will include that in the PR.

Would @errorists or @andmironov be willing to help convert the DAI logos to our required formats? :)

I am willing, always for the mysterious StatusSceptre! :)

and the assets can be found here
I used this image for reference since everyone seems to do their own take on the SAI badge

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


__Work for 0.287 ETH (50.72 USD @ $176.74/ETH) has been submitted by__:

  1. @acolytec3

@StatusSceptre please take a look at the submitted work:

  • PR by @acolytec3

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


__The funding of 0.287 ETH (48.43 USD @ $168.73/ETH) attached to this issue has been approved & issued to @acolytec3.__

Was this page helpful?
0 / 5 - 0 ratings

Related issues

mfekadu picture mfekadu  路  3Comments

rachelhamlin picture rachelhamlin  路  3Comments

annadanchenko picture annadanchenko  路  3Comments

churik picture churik  路  3Comments

yevh-berdnyk picture yevh-berdnyk  路  4Comments