Status-react: Crash at attempt to use second multiaccount with keycard

[churik]

Description

Type: Bug

Summary: if you have several keycards, at attempt to create a second account with keycard Status will crash.

Expected behavior

can use 2 accounts with keycard

Actual behavior

crash on "finishing up" stage and at attempt to login

Reproduction

Prerequisites: have several keycards with pre-installed keycard applet

• Open Status
• Create account with keycard
• Log out
• Create second account with another keycard

Additional Information

• Status version: nightly 24/09/2019
• Operating System: Android

Logs

Full logcat: second_account.log

[churik]

@guylouis should it be the part of v1 release?

[guylouis]

cc @yenda for his advice on the root problem
@rachelhamlin wdyt regarding priorities ?

I personally think we should have it part of v1, it comes down to being able to support :

• status manages several wallets(=multiaccounts)
• any multiaccount at creation can either be protected by a password on the phone, or by a keycard

If for some reasons (priorities) we prevent not supporting more than one keycard wallet then we should have a warning pop-up when the user tries to set-up a second one

[guylouis]

cc @dmitryn too FYI

[rachelhamlin]

@yenda pinging you again - do you have insight into the problem?

It seems logical to include. I am worried about the size of the v1 backlog. But if we don't support multiple keycards in v1, we need screens to explain that.

[dmitryn]

@rachelhamlin it's fixed in https://github.com/status-im/status-react/pull/9053

[rachelhamlin]

Awesome @dmitryn!

[guylouis]

@chu @rachelhamlin sorry if the question was already addressed and the answer is obvious: in the new QA process who closes issues like this one ?

[yenda]

@guylouis if the PR that claims to fix is merged it is closed automatically