Status-react: Unable to sign in or restore account if password cointains ' symbol (quotemark)

[churik]

Description

Type: Bug
Summary: using password with quotemark ' leads to error:

08-05 06:24:58.791  4332  4732 E GoLog   : failed to set key pragma
08-05 06:24:58.796  4332  4391 D ReactNativeJS: DEBUG [status-im.utils.handlers:32] - Handling re-frame event:  :multiaccounts.login.callback/login-success
08-05 06:24:58.810  4332  4391 E ReactNativeJS: ERROR [status-im.multiaccounts.login.core:125] - failed to login failed to set key pragma
08-05 06:24:58.820  4332  4392 E unknown:ReactNative: console.error: "ERROR [status-im.multiaccounts.login.core:125] - failed to login failed to set key pragma", stack:
08-05 06:24:58.820  4332  4392 E unknown:ReactNative: [email protected]:96:29
08-05 06:24:58.820  4332  4392 E unknown:ReactNative: hca@7201:45
08-05 06:24:58.820  4332  4392 E unknown:ReactNative: a@7303:53
08-05 06:24:58.820  4332  4392 E unknown:ReactNative: c@91168:136
08-05 06:24:58.820  4332  4392 E unknown:ReactNative: b@91163:24
08-05 06:24:58.820  4332  4392 E unknown:ReactNative: <unknown>@33320:26
08-05 06:24:58.820  4332  4392 E unknown:ReactNative: <unknown>@33605:52
08-05 06:24:58.820  4332  4392 E unknown:ReactNative: Jb@11905:35
08-05 06:24:58.820  4332  4392 E unknown:ReactNative: gc@3075:47

and user automatically logged out

Expected behavior

can use password with ' symbol

Actual behavior

error

Reproduction

• Open Status
• Try to create account with password that contains '

Additional Information

• Status version: nigthly 04/08/2019.
• Operating System: Android, iOS

Logs

Full test and logcat can be found here

[churik]

@cammellos @rachelhamlin imo should be fixed in scope of V1

[cammellos]

@dshulyak I can check on our side (status-protocol-go), but are you hashing the password on yours (browsers etc), as if not that's likely the reason?

Because breaking changes are ok,we could also hash it before sending it to status-go (so that Login will get the hashed password), sounds safer and we don't really have to worry about this anymore, but not sure if there are other unintended consequences (I can't see any)

[rachelhamlin]

Thanks @churik. Can we begin flagging v1 release issues with the label? cc @annadanchenko

[dshulyak]

@cammellos you are right it is passed as it is

[corpetty]

we could also hash it before sending it to status-go (so that Login will get the hashed password), sounds safer and we don't really have to worry about this anymore

very much this.

[yenda]

@cammellos I can assign the issue to myself and do the hashing on status-react side or do you still plan to do it

@corpetty can we use sha3 for web3.utils?

[cammellos]

up to you, is to be implemented in status-react, i am on some other tasks
now, but can pick up later if you have your plate full

On Tue, Aug 27, 2019, 18:02 yenda [e-mail] wrote:

@cammellos https://github.com/cammellos I can assign the issue to
myself and do the hashing on status-react side or do you still plan to do it

@corpetty https://github.com/corpetty can we use sha3 for web3.utils?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/status-im/status-react/issues/8702?email_source=notifications&email_token=AAHYJMDUWZLVTXKB6FLUNBDQGVFZBA5CNFSM4IJMOKYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5IH7DY#issuecomment-525369231,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAHYJMBQRWYX4LNG7PREPI3QGVFZBANCNFSM4IJMOKYA
.

[yenda]

I can take it np

On Tue, Aug 27, 2019, 18:04 Andrea Maria Piana [e-mail]
wrote:

up to you, is to be implemented in status-react, i am on some other tasks
now, but can pick up later if you have your plate full

On Tue, Aug 27, 2019, 18:02 yenda [e-mail] wrote:

@cammellos https://github.com/cammellos I can assign the issue to
myself and do the hashing on status-react side or do you still plan to
do it

@corpetty https://github.com/corpetty can we use sha3 for web3.utils?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://github.com/status-im/status-react/issues/8702?email_source=notifications&email_token=AAHYJMDUWZLVTXKB6FLUNBDQGVFZBA5CNFSM4IJMOKYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5IH7DY#issuecomment-525369231
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AAHYJMBQRWYX4LNG7PREPI3QGVFZBANCNFSM4IJMOKYA

.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/status-im/status-react/issues/8702?email_source=notifications&email_token=AAJAMKOQKIFMMG75JRLSNZTQGVGAXA5CNFSM4IJMOKYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5IIGQQ#issuecomment-525370178,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJAMKIZLVSS6I7APBWHUVDQGVGAXANCNFSM4IJMOKYA
.