Status-react: Keyboard overlaps sign button if you tap on sign after changing "Recipient" or "Asset" field on Send Transaction screen

Created on 29 Jul 2019 · 24Comments · Source: status-im/status-react

Description

Type: Bug
Summary: when you change "Recipient" or "Asset" after setting an amount and tapping Back, at attempt to sign transaction keyboard remains opened and overlaps "sign" button.

Expected behavior

no overlapping

Actual behavior

photo_2019-07-29 11 09 11

Reproduction

Open Status
Go to wallet -> send
Set recepient, asset, amount
Change recepient or asset
Try to sign transaction

Additional Information

Status version: nightly 29/07/2019, release 0.14.0 (build 16)
Operating System: iOS

bug core-ui-grooming high-severity ios release wallet

Source

churik

All 24 comments

cc @rachelhamlin

churik on 13 Aug 2019

This also happens when I initiate a Tx from the wallet in general. 😕
It's a blocker for v 0.14 so I'm adding a regular release label as well.

rachelhamlin on 14 Aug 2019

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

__This issue now has a funding of 100.0 DAI (100.0 USD @ $1.0/DAI) attached to it.__

If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
- Want to chip in? Add your own contribution here.
- Questions? Checkout Gitcoin Help or the Gitcoin Slack
- $149,454.19 more funded OSS Work available on the Gitcoin Issue Explorer

gitcoinbot on 6 Sep 2019

You're approved @bshevchenko!

rachelhamlin on 11 Sep 2019

@rachelhamlin thanks! I'm having issues with project installation, trying to reach https://chat.status.im/ but no luck (even via VPN). Is it down or something?

bshevchenko on 11 Sep 2019

https://chat.status.im/ isn't actually live @bshevchenko; we're developing for mobile only right now.

Take a look at this quick start and see if it helps you? https://status.im/build_status/status_react_quickstart.html

rachelhamlin on 11 Sep 2019

@rachelhamlin with this quick start I have the same problem:

copying path '/nix/store/b9zbysdvs1djwg6c54gf8bxnvy3iqmlp-tzdata-2018g' from 'https://nix-cache.status.im'...
copying path '/nix/store/nf6zg5ha82nh1561a1l97w6ky4n2pn0a-xz-5.2.4' from 'https://nix-cache.status.im'...
error: build of '/nix/store/0f47hb96ikir1vway0imyyjsb2pk6jfz-status-go-develop-76d184b-ios.drv', '/nix/store/2j1kdh49d83ax37z42fq5gqjdj6nxh75-stdenv-darwin.drv', '/nix/store/2v54skp2jfm9c0ij4p5d4cirxxirzjb2-file-5.35.drv', '/nix/store/5grmn503lbiz1ca6pfcsvhas6prj13ry-StatusIm-Mobile-0.0.1.drv', '/nix/store/800l2ps3lb5dblbzf6jz2q89f89xha5k-unzip-6.0.drv', '/nix/store/9dlbv23rxb3lbr0n4k0b3xc49bxp4a67-curl-7.64.0.drv', '/nix/store/a0aix5lvz46rd50sc11ixm8cqhnx09vn-jq-1.6.drv', '/nix/store/f2xc8zp7znaannj9q9byy3zksrwg37rj-git-2.19.2.drv', '/nix/store/f458d7k73p245c2zmq55ys0z2aa4i8fj-leiningen-2.8.3.drv', '/nix/store/fwxlb9x9ghfh3gh1876sjxwg082y6m66-clojure-1.10.0.411.drv', '/nix/store/h4hx8b16pk3fvk2afr9dg28kd5ma2xij-ruby-2.5.3.drv', '/nix/store/k8q3yla32j4r5cjcbgz8x2ba1xmsbbnh-nodejs-10.15.0.drv', '/nix/store/l0ssijbwz3bdl0axhjd6wvir4l0ls7h8-python-2.7.15.drv', '/nix/store/m7s9yfma68lmxqslyllaqq1hn8q7rhn3-ps-1003.1-2008.drv', '/nix/store/n02kb7qpjblh0ccb917xra9j8v0j8dkc-bundler-1.17.2.drv', '/nix/store/r91yssj1panwy2wwj3sgg28qpyci27h4-cocoapods-1.5.3.drv', '/nix/store/scqbidqr61njcfv4qzj4gw3pjpd0jy2q-apache-maven-3.6.0.drv', '/nix/store/sn9zxjphg1x7231yv4n4x42mc5g02hav-yarn-1.13.0.drv', '/nix/store/x4r8g7s3jlp0x7f7rz4awspngk3g1f64-procps-1003.1-2008.drv', '/nix/store/x6cn2pzrjkcbnbln04vmsihk5mmmjayg-wget-1.20.1.drv', '/nix/store/x9w7zd9lb2fnk9vgf7dkmyf10m4xx4r4-lsof-4.91.drv', '/nix/store/yy455b8l7yck3g11yz8baiq7n1g3ia9h-watchman-4.9.0.drv' failed
make: *** [Makefile:304: _startdev-ios-simulator] Error 1

it's the end of the log file
where's the best place to get help on this?

bshevchenko on 13 Sep 2019

@rachelhamlin it happens to me on the very firsrt command make startdev-ios-simulator

bshevchenko on 13 Sep 2019

@bshevchenko the log you pasted doesn't seem to contain the reason for the error. Can you please create a gist of the complete log?

pedropombeiro on 13 Sep 2019

@PombeirP https://gist.github.com/bshevchenko/ffa2aa2c33de0a3025227ff0fc1af28e

bshevchenko on 13 Sep 2019

👍1

@PombeirP I'm on macOS mojave 10.14.6 (18G87)

bshevchenko on 13 Sep 2019

OK, the issue is here:

hash mismatch importing path '/nix/store/22xhg1i229h2ngiwz5j2w1f2f606rynw-ruby2.5.3-ruby-macho-1.2.0';
  wanted: sha256:0p6kidp6p61i03jq82fc6049bbg3s0c7n7zyibmxvz1b7kx5sk8k
  got:    sha256:18x66j0sjnikwzzfv4zk77k3g8igy51iflf49mqljhl0wll6vnlm

We're being occasionally bitten by this issue, and still don't have a fix for it. Maybe you can the following:

Ensure you are on latest develop (or rebased on it);
try running nix-store --delete /nix/store/22xhg1i229h2ngiwz5j2w1f2f606rynw-ruby2.5.3-ruby-macho-1.2.0 and try running make startdev-ios-simulator again?
If that doesn't work, I'd try cleaning the whole Nix store by running make nix-purge (all required archives will be re-downloaded).

pedropombeiro on 13 Sep 2019

@PombeirP thanks, but 2 didn't help

keiras-iMac:status-react bruce$ make nix-purge sudo rm -rf /nix ~/.nix-profile ~/.nix-defexpr ~/.nix-channels ~/.cache/nix ~/.status .nix-gcroots Password: keiras-iMac:status-react bruce$ make startdev-ios-simulator -bash: /Users/bruce/.nix-profile/bin/make: No such file or directory

How to build project after make nix-purge?

bshevchenko on 15 Sep 2019

@bshevchenko Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot on 20 Sep 2019

@PombeirP thanks, but 2 didn't help

keiras-iMac:status-react bruce$ make nix-purge sudo rm -rf /nix ~/.nix-profile ~/.nix-defexpr ~/.nix-channels ~/.cache/nix ~/.status .nix-gcroots Password: keiras-iMac:status-react bruce$ make startdev-ios-simulator -bash: /Users/bruce/.nix-profile/bin/make: No such file or directory

How to build project after make nix-purge?

Hmm, I haven't seen that before. Are you by any chance running this from inside a Nix shell? You should be in a regular OS shell, not inside a Nix one.

pedropombeiro on 23 Sep 2019

@PombeirP @gitcoinbot regular OS shell

bshevchenko on 23 Sep 2019

❤1

@bshevchenko what I find strange is that make is pointing to /Users/bruce/.nix-profile/bin/make (mine is pointing to /usr/bin/make). Maybe the best is to start the setup procedure again from the beginning (i.e. run sudo rm -rf /nix ~/.nix-profile ~/.nix-defexpr ~/.nix-channels ~/.cache/nix and run make run-android again, from a new shell)

pedropombeiro on 25 Sep 2019

@PombeirP and again no luck :( https://gist.github.com/bshevchenko/78d4f35c64d2df01c244710c322e6d5d

bshevchenko on 25 Sep 2019

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot on 29 Sep 2019

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

__Work has been started__.

These users each claimed they can complete the work by 1 week, 3 days ago.
Please review their action plans below:

1) tbenr has been approved to start work.

I should be able to fix this relatively quickly

Learn more on the Gitcoin Issue Details page.

gitcoinbot on 30 Sep 2019

@tbenr Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!