Status-react: [Onboarding] Recovery

[flexsurfer]

Pincode not in the scope of this PR

Acceptance criteria:

1. pixel perfect
2. it's possible to recover account

Figma: https://www.figma.com/file/dEIljL7UPbXgsZUA0Q4qlE5E/Onboarding?node-id=927%3A14702

[rachelhamlin]

@annadanchenko I think this flow is sufficient for migrating users, wdyt? User recovers an account + creates a pin code when they do. We could explain this step in the marketing comms.

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__This issue now has a funding of 500.0 DAI (500.0 USD @ $1.0/DAI) attached to it.__

• If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
  
  
  
  • Want to chip in? Add your own contribution here.
  
  
  • Questions? Checkout Gitcoin Help or the Gitcoin Slack
  
  
  • $85,174.80 more funded OSS Work available on the Gitcoin Issue Explorer
  
  

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__Work has been started__.

These users each claimed they can complete the work by 10 months from now.
Please review their action plans below:

1) pacamara has been approved to start work.

I have completed several bounties on the Status front-end previously, https://github.com/status-im/status-react/pulls?utf8=%E2%9C%93&q=is%3Apr+pacamara, and am familiar with the code base and working with the team. Action plan: modify code under ui/screens/accounts according to the new designs.

Learn more on the Gitcoin Issue Details page.

[StatusWrike]

➤ Rachel Hamlin commented:

Waiting to get bounty worker approved; will then estimate date.

[pacamara]

@rachelhamlin @StatusSceptre Thanks for the approval, getting started :+1:

[flexsurfer]

password confirmation in this PR https://github.com/status-im/status-react/pull/8234

[pacamara]

@flexsurfer Got it, cheers :+1:

[gitcoinbot]

@pacamara Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@pacamara Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[pacamara]

@gitcoinbot Still working on this -- had some difficulty with getting new nix build system working on my env, that's resolved now and am coding. Should have PR ready by end of week.

[rachelhamlin]

@pacamara let us know if you need any help. Thanks for sticking with it!

[pacamara]

@rachelhamlin Thanks I will :) Still on track for PR by end of week.

[gitcoinbot]

@pacamara Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@pacamara Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[pacamara]

@gitcoinbot Am still working on this, bit slower than expected, expect now to submit PR sometime tomorrow Tuesday :+1:

[gitcoinbot]

@pacamara Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@pacamara Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[pacamara]

Have updated the WIP PR #8519 :+1:

[flexsurfer]

hey @pacamara have you seen in the description Pincode not in the scope of this PR ? password should be used, btw #8234 has been merged

[pacamara]

@flexsurfer Ugh missed that! But the UI screenshots show the pincode entry screens. Does that mean the UI is in scope, but recovery using the pincode isn't? In which case am almost done.

[flexsurfer]

@pacamara we already have pincode UI implemented, but anyway we can look at yours :) this PR doesn't include any work on pincode , password flow should be used , that's why i mentioned #8234 it has password flow, and it should be used here, thanks and sorry for the confusion

[pacamara]

@flexsurfer No worries, I should have read that note and queried the scope earlier :)

So which of those screenshots are in scope? Just these four: "Recover", "Recover with phrase", "Recover loading" and "Wrong recovery"?

[flexsurfer]

five , "Recover success" as well, re-encrypt button should lead to password screen

[pacamara]

Gotcha, will rebase and fixup. Thanks @flexsurfer

[gitcoinbot]

@pacamara Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@pacamara Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[pacamara]

8519 updated here, all UI changes done and UI handover to #8234 works. Still some work to do on ensuring the correct account gets recovered.

[pacamara]

@flexsurfer @rachelhamlin OK #8519 is done :) Recovers account correctly. Only outstanding issue is use of resolve to avoid a circular dependency, probably implies a refactor of existing code but would like to discuss that first. In any case this does not affect testability. :beers:

[gitcoinbot]

@pacamara Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[pacamara]

All review suggestions implemented in latest commit (above), except for a couple where more clarification is needed.

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__Work for 500.0 DAI (500.0 USD @ $1.0/DAI) has been submitted by__:

1. @pacamara

@StatusSceptre please take a look at the submitted work:

• PR by @pacamara

---

• Learn more on the Gitcoin Issue Details page
• Want to chip in? Add your own contribution here.
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $142,853.22 more funded OSS Work available on the Gitcoin Issue Explorer

[gitcoinbot]

⚡️ A tip worth 450.00000 DAI (450.0 USD @ $1.0/DAI) has been granted to @pacamara for this issue from @StatusSceptre. ⚡️

Nice work @pacamara! Your tip has automatically been deposited in the ETH address we have on file.

• $144349.70 in Funded OSS Work Available at: https://gitcoin.co/explorer
• Incentivize contributions to your repo: Send a Tip or Fund a PR
• No Email? Get help on the Gitcoin Slack

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__This Bounty has been completed.__

Additional Tips for this Bounty:

• StatusSceptre tipped 450.0000 DAI worth 450.0 USD to pacamara.

---

• Learn more on the Gitcoin Issue Details page
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $143,849.70 more funded OSS Work available on the Gitcoin Issue Explorer