Status-react: [Profile] Other profile screen UI

[flexsurfer]

crossed element not in the scope of this PR

Acceptance criteria:

1) pixel perfect
2) new design introduced
3) Profile details introduced
4) prompts introduced

Figma:
https://www.figma.com/file/TNCyHKtR3sx5EL6YznFWUa4O/Profile?node-id=510%3A3116

[StatusWrike]

➤ Julien Eluard commented:

Estimated to 1 day of work

[tbenr]

@hesterbruikman @flexsurfer do we want the icon\username to be inside the toolbar? in figma seems to be inside (i can see the lightgrey separator there).

@flexsurfer is toolbar planned to be replaced with something else? https://github.com/status-im/status-react/blob/de0d98da20baf9e6ece6fc3f562e6db181c50375/src/status_im/ui/components/toolbar/view.cljs#L114-L116

[flexsurfer]

hey @tbenr, no, icon\username should be outside toolbar, we are not planning to replace toolbar in near future, so you can just use a view with 1px height for the line

[flexsurfer]

btw @hesterbruikman in profile details do we want to show user's wallet address ? @tbenr currently i think there should be only the name

[hesterbruikman]

btw @hesterbruikman in profile details do we want to show user's wallet address ? @tbenr currently i think there should be only the name

Checked the UX review notes.

• Wallet address of user B should be visible to user A if user B has added user A as a (trusted) contact.
• Send transaction to user B should be visible to user A if user B has added user A as a (trusted) contact.

So yes, the designs still include Wallet address. Reason being that Send transaction exposes the address anyway and I'd rather have this be transparent by also showing the wallet address.

@andmironov can you please confirm that wallet address should be displayed in Other user's profile view for people who have added you as a contact?

[errorists]

hey, let's stop there for a minute.

hey @tbenr, no, icon\username should be outside toolbar, we are not planning to replace toolbar in near future, so you can just use a view with 1px height for the line

that's not true :) it's just a different type of toolbar. We have the regular height one, and the larger one which the profiles use. The larger one needs implementing. So @tbenr was correct, the icons and username are inside the larger toolbar. Here are the reference designs for both

[flexsurfer]

@errorists yeah but it's not in the scope of this PR for sure

[errorists]

@flexsurfer sure but it's not exactly crossed out on the first mockup and it was asked :) I'm just making sure profiles are not shipped with the incorrect design.

[rachelhamlin]

Can we please include the toolbar? We'll size it as a large bounty. Otherwise we accrue more design debt, which we'll then try to find another contractor for. :) Would be great to do it now if @tbenr is able and willing.

[tbenr]

@rachelhamlin I can work on that too.

[StatusSceptre]

Hey @hesterbruikman @errorists @flexsurfer

For bounties labeled as Large, I need some more info before I can assign a bounty

• Proposed bounty amount = Large (8 hrs)
• Estimated time to completion = Day
• Estimated required experience level = ?
• Why we’re outsourcing it = ?

Can you please add this info and I'll go ahead and get the bounty approved by Finance.

Thanks!

[rachelhamlin]

@StatusSceptre I can answer these.

• Proposed bounty amount = Large (8 hours) - _TBD how this translates into ETH, do you need my input?_
• Estimated time to completion = ~ 1 day to implement, 2-3 for testing & bug fixing
• Estimated required experience level = Clojure and RN experience required, seniority unimportant
• Why we're outsourcing = this is a v1 must-have and we are short of people to implement the current v1 scope

[tbenr]

@flexsurfer any reason why block user is not there? do i need to strictly follow figma (where block user is at the very bottom without icon?)

[hesterbruikman]

@flexsurfer any reason why block user is not there? do i need to strictly follow figma (where block user is at the very bottom without icon?)

To the best of my knowledge block/unblock user should be included and is not in the above images because we hadn't realized they were missing when the images where taken to create this issue.

[flexsurfer]

thanks @tbenr updated the description, nicknames aren't in the scope

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__This issue now has a funding of 400.0 DAI (400.0 USD @ $1.0/DAI) attached to it.__

• If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
  
  
  
  • Want to chip in? Add your own contribution here.
  
  
  • Questions? Checkout Gitcoin Help or the Gitcoin Slack
  
  
  • $136,137.46 more funded OSS Work available on the Gitcoin Issue Explorer
  
  

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__Workers have applied to start work__.

These users each claimed they can complete the work by 12 months from now.
Please review their action plans below:

1) tbenr has applied to start work _(Funders only: approve worker | reject worker)_.

Already started working on it!

Learn more on the Gitcoin Issue Details page.

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__Work has been started__.

These users each claimed they can complete the work by 9 months, 2 weeks from now.
Please review their action plans below:

1) tbenr has been approved to start work.

Already started working on it!
2) tbenr has been approved to start work.

Already started working on it!

Learn more on the Gitcoin Issue Details page.

[tbenr]

@flexsurfer I don't see remove-contact event\fx implemented. For the moment I implement only UI ok?

[flexsurfer]

hey @tbenr , this should work

(fx/defn remove-contact
  {:events [:contact.ui/remove-contact-pressed]}
  [{:keys [db] :as cofx}
   {:keys [public-key] :as contact}]
  (fx/merge cofx
            {:db            (update db :contacts/contacts dissoc public-key))
             :data-store/tx [(contacts-store/delete-contact-tx public-key)]}))

[tbenr]

@flexsurfer great I'll integrate it

[tbenr]

@flexsurfer but I make public-key to be second parameter so it is the dual of add-contact. Changing add-contact to receive contact was requiring a bit more work so I gave up.

[flexsurfer]

yes sure, sounds fine

[gitcoinbot]

@tbenr Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@tbenr Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[tbenr]

@flexsurfer @hesterbruikman @gitcoinbot sorry for being late on this and the other issue I have in charge.. I over-estimated my free time for these weeks. Now i'll be offline for vacation for a couple of weeks. When i'll be back I should have more time for contributions, so I can close this and start on the other.

[gitcoinbot]

@tbenr Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@tbenr Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@tbenr Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@tbenr Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@tbenr Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@tbenr Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@tbenr Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@tbenr Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[tbenr]

@gitcoin i'll continue next week

[gitcoinbot]

@tbenr Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@tbenr Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@tbenr Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@tbenr Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

@tbenr due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

• [x] reminder (3 days)
• [x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

@tbenr due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

• [x] reminder (3 days)
• [x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[rachelhamlin]

Oops! For our team - @tbenr is planning to pick this back up shortly.

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

@tbenr due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

• [x] reminder (3 days)
• [x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

@tbenr due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

• [x] reminder (3 days)
• [x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@tbenr Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@tbenr Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@tbenr Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@tbenr Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

@tbenr due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

• [x] reminder (3 days)
• [x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

@tbenr due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

• [x] reminder (3 days)
• [x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[tbenr]

@gitcoinbot just pushed a WIP PR

[tbenr]

@gitcoinbot @StatusSceptre I submitted the bounty in gitcoin but due to ethereum congestion the tx took a couple of days to be mined. https://etherscan.io/tx/0x66184ea1c60eeb0287a1e07b7170f110d83be387895f90d7c1ecf9e1e1338ab2
now the gitcoin portal doesn't reflect the submission. Who can have a look or contact someone in gictoin?

[tbenr]

@StatusSceptre
reading the contract https://etherscan.io/address/0x2af47a65da8cd66729b4209c22017d6a5c2d2400

I can see fulfillment:

anyone form gitcoin who can have a look?

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__Work for 400.0 DAI (400.0 USD @ $1.0/DAI) has been submitted by__:

1. @tbenr

@StatusSceptre please take a look at the submitted work:

• PR by @tbenr

---

• Learn more on the Gitcoin Issue Details page
• Want to chip in? Add your own contribution here.
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $158,803.74 more funded OSS Work available on the Gitcoin Issue Explorer

[octavioamu]

@tbenr @StatusSceptre is fixed now, was a problem with the sync on our side. Now should be ok but feel free to ping me if something is wrong.

[gitcoinbot]

⚡️ A tip worth 48.00000 DAI (48.0 USD @ $1.0/DAI) has been granted to @tbenr for this issue from @StatusSceptre. ⚡️

Nice work @tbenr! Your tip has automatically been deposited in the ETH address we have on file.

• $148679.35 in Funded OSS Work Available at: https://gitcoin.co/explorer
• Incentivize contributions to your repo: Send a Tip or Fund a PR
• No Email? Get help on the Gitcoin Slack

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__The funding of 400.0 DAI (400.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @tbenr.__

Additional Tips for this Bounty:

• StatusSceptre tipped 48.0000 DAI worth 48.0 USD to tbenr.

---

• Learn more on the Gitcoin Issue Details page
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $148,279.35 more funded OSS Work available on the Gitcoin Issue Explorer