Status-react: A limit of 20 CryptoKitties is displayed in the collectibles list in the wallet with incorrect order

[SlizkovaGanna]

Type: Bug

Summary: As a user, I would like to see the correct number of my collectibles in the wallet, in the right order.
Currently, only 20 CK are shown, without any option to show more of them.
As a user, I would be very confused

Expected behavior

The exact number of collectibles should be displayed in the correct order

Actual behavior

Only 20 CK are displayed in a different order from the App

Reproduction

1. Recover/open an account that has more than 20 collectibles.
2. Navigate to the wallet and click '>' button next to CryptoKitties collectibles in the list.

1. List through them to make sure that the valid number of collectibles is displayed
2. Go to the CK App to check that the order that collectibles are displayed is the same

Collectibles list, top of the list:

App list, top of the list:

Additional Information

Status version: 0.9.31 (1811211215); node 27700aa2 (Nov 22 nightly build)
Operating System: iOS, Android

[SlizkovaGanna]

Was not sure if this is a bug or a feature request, but according to the description in https://github.com/status-im/status-react/pull/5017 - it's a bug.
@flexsurfer your feedback is appreciated

[flexsurfer]

it's a bug for sure, thank you

[asemiankevich]

@hetvart please add a test for this when you have time. This is definitely a regression

[hetvart]

I set it as the top priority task!

[hetvart]

Postponed it. Probably till I get an account with the needed amount of test collectibles.

[flexsurfer]

@asemiankevich did you test more than 20 CKs ? and it worked?

[asemiankevich]

i dont remember exactly how many kitties i did have once testing https://github.com/status-im/status-react/pull/5017. However now i have 23 kitties and only 20 is shown.

[flexsurfer]

i mean i'm not sure it's regression, i remember i didn't have more than 20 CKs, so i couldn't test properly

[asemiankevich]

wrong order is a regression anyway

[status-github-bot[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[status-github-bot[bot]]

This issue has been automatically closed. Please re-open if this issue is important to you.

[asemiankevich]

@rachelhamlin can we consider this?

[rachelhamlin]

Adding to nice-to-have list, not blocker :)

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__This issue now has a funding of 90.0 DAI (90.0 USD @ $1.0/DAI) attached to it.__

• If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
  
  
  
  • Want to chip in? Add your own contribution here.
  
  
  • Questions? Checkout Gitcoin Help or the Gitcoin Slack
  
  
  • $68,343.09 more funded OSS Work available on the Gitcoin Issue Explorer
  
  

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__Work has been started__.

These users each claimed they can complete the work by 2 weeks, 6 days from now.
Please review their action plans below:

1) samgos has started work.

React is my bread to my butter and I'm able to read through other's code pretty well, let's give it a shot, will be done ASAP.

Learn more on the Gitcoin Issue Details page.

[StatusSceptre]

Welcome aboard @samgos - you're doing to need to write Clojure and compile it to RN. Any Clojurescript familiarity? Here's our quickstart, just ping us with any questions, we're happy to help.

[samgos]

Thank you for the approval, I will not let you down, Clojure no but the JVM yes. I'm sure I'll be fine, will do.

[samgos]

Got the all the kitties showing, so now it's just a matter indexing them in the correct order, nearly there!

[StatusSceptre]

Wow, awesome work @samgos! Thanks for the update.

[samgos]

I'm afraid I cannot find a viable solution for indexing the kitties correctly due to Clojure's abnormal behaviour when it comes to mapping and indexing values. Alongside working with http-get-n (which I can't find out for the life of me what library extends from this) and it's exclusivity to use mapv, I did find that filterv worked perfectly for maintaining the order of the array but was faced with:

TypeError: cb is not a function. (In 'cb(value)', 'cb' is "TypeError: Network request failed")

I have spent a surplus of 40 hours on this task, so it is no longer financially viable for me to continue. I'm sure you're developers could easily fix the sorting in a few minutes or perhaps give me some guidance, I would be more than happy to finish the job if so. I am not adept at Clojure and this is my first time using the language. Regardless I fixed the major problem of this issue I am just wondering am I still compliant for the reward.

Repo: https://github.com/samgos/status-react

[samgos]

Opened a WIP PR at #9810, hopefully it may shine some light on how to implement the indexing.

[StatusSceptre]

Thanks for the great effort @samgos! I'll definitely compensate you for your time.

[samgos]

That's awesome I'll submit the work on gitcoin then, forgive me for not sorting the indexing but at least the kitties are showing!