Status-react: New messages counter is shown for already seen messages

Created on 8 May 2018 · 35Comments · Source: status-im/status-react

User Story

As a user I don't want to see new messages counter when all messages are already seen

Description

Type: Bug

Summary: New messages counter doesn't disappear until navigating to home view if a new message was received when viewing another user profile or group chat info. Even if a user already read all new messages and sent new one on the chat the counter is still present

Expected behavior

New messages counter disappears when a user navigates to a chat with new messages

Actual behavior

New messages counter is still shown when user returns to a chat with new messages from profile or group info view

Reproduction

One-to-one chat:

Open Status on 2 devices
Create 2 users and start a chat between them
As user A tap Chat options -> View profile
As user B send a message to user A
As user A return to the chat view and send a message to user B

Group chat:

Open Status on 2 devices
Create 2 users
Create a group chat
As user A click Chat options -> Group info
As user B send a message in the group chat
As user A return to the chat view and send a message in the group chat

Public chat:

Open Status on 2 devices
Create 2 users and join the same public chat
As user B send a message in the public chat
As user A tap user's B picture and open his profile
As user B send one more message in the chat
As user A return to the chat view and send a message

Additional Information

Status version: 6fc03fc2, nightly build from May 8
Operating System: Android, iOS

bounty bounty-s bug chat chat-reliability low-severity

Source

yevh-berdnyk

👍3

All 35 comments

The issue is still present in 0.9.20 build. But, it does not seem to be related to #4820 in which the message counter does not disappear even if the chat is opened again.

lukaszfryc on 19 Jun 2018

@lukaszfryc @yevh-berdnyk is this issue still relevant?

andytudhope on 23 Aug 2018

@andytudhope yes, it's still reproducible on both iOS and Android

yevh-berdnyk on 27 Aug 2018

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

__This issue now has a funding of 120.0 DAI (120.0 USD @ $1.0/DAI) attached to it as part of the Status-im fund.__

If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
- Want to chip in? Add your own contribution here.
- Questions? Checkout Gitcoin Help or the Gitcoin Slack
- $51,507.11 more funded OSS Work available on the Gitcoin Issue Explorer

gitcoinbot on 26 Jan 2019

@StatusSceptre can I work on this issue?

pbteja1998 on 26 Jan 2019

Feel free to open a pull request if you’re inclined to work on it! We’re happy to accept commits.

StatusSceptre on 26 Jan 2019

@mul1sh would be happy to have you dive into the fix, Status works with CLJS not JS would you be comfortable with it? If you feel confident to start work I can approve you no problem!

StatusSceptre on 26 Jan 2019

@StatusSceptre yes i'm very confident with CLJS so i can definitely handle this task. thanks 🙂

mul1sh on 26 Jan 2019

You've been approved to start work @mul1sh!

StatusSceptre on 26 Jan 2019

👍1

@StatusSceptre awesome thanks

mul1sh on 26 Jan 2019

@StatusSceptre sorry, but i'm having a bit of an issue deploying the app on my end. So let me stop the work for now so that i don't block this issue for long and then once I understand how to correctly deploy the app, I'll jump in future issues.

Sincere apologies for the inconvenience caused

mul1sh on 29 Jan 2019

@mul1sh we want to make sure you can build the app to successfully work, there is no rush on this issue. Have you tried following along with https://status.im/build_status/

Would love to see you continue work on this!

Status, a Mobile Client for Ethereum 2.0

StatusSceptre on 29 Jan 2019

If you still have problems after following along there please drop a message here:

Check out this public chat on the Status app: https://get.status.im/chat/public/status-core

Join the public chat: #status-core in Status

StatusSceptre on 29 Jan 2019

@StatusSceptre ohh nice, thanks. I didn't know the docs for the app were available and the way i wasted so much time trying to do it on my own 🤦‍♂️ Anyway thanks for sharing, let me try building the app as per the docs.

mul1sh on 29 Jan 2019

I can confirm issue still present with 0.9.33 Develop/Release builds.
Message counter (near the top-left < button on chat view) does not disappear when navigating to chat view from user Profile / Wallet modal / Group info(for Group chat) views

Serhy on 1 Feb 2019

No problem @mul1sh just keep us updated on your work if you have a WIP or need any other assistance!

pablanopete on 4 Feb 2019

@mul1sh are you still working on this issue?

StatusSceptre on 11 Feb 2019

Issue Status: 1. Open 2. Cancelled

__The funding of 120.0 DAI (120.0 USD @ $1.0/DAI) attached to this issue has been cancelled by the bounty submitter__

Questions? Checkout Gitcoin Help or the Gitcoin Slack
$56,671.33 more funded OSS Work available on the Gitcoin Issue Explorer

gitcoinbot on 11 Feb 2019

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

__This issue now has a funding of 230.0 DAI (230.0 USD @ $1.0/DAI) attached to it as part of the Status-im fund.__

If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
- Want to chip in? Add your own contribution here.
- Questions? Checkout Gitcoin Help or the Gitcoin Slack
- $56,901.33 more funded OSS Work available on the Gitcoin Issue Explorer

gitcoinbot on 11 Feb 2019

@StatusSceptre @pablanopete yes I'm still working on this issue, sorry I forgot to reply.

I tried a number of fixes last week and I found one that finally sticks, was going to push it after i'm done testing, but i see the issue has been cancelled now 🙁 .

mul1sh on 11 Feb 2019

@mul1sh it's still active!

StatusSceptre on 11 Feb 2019

🎉1

@StatusSceptre awesome will submit to it soon then :)

mul1sh on 11 Feb 2019

Commits > Comments ;)

@mul1sh says he's working on it but feel free to collaborate with him @leonardohof !

StatusSceptre on 12 Feb 2019

👍1

@mul1sh are you still working on this?

StatusSceptre on 24 Feb 2019

@StatusSceptre yes I am, sorry for the late reply. But I will PR in a few hours 🙂 thanks.

mul1sh on 25 Feb 2019

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

__Work has been started__.

These users each claimed they can complete the work by 10 months, 1 week from now.
Please review their action plans below:

1) bitsikka has started work.

I would as needed modify status-im.ui.screens.navigation/navigate-back which is used in all three cases. I will make use of status-im.chat.models/mark-messages-seen in it.

Learn more on the Gitcoin Issue Details page.

gitcoinbot on 1 Mar 2019

oops! didn't realize you were working on this @mul1sh. Are you still working on it?

I was browsing through issues in gitcoin and saw that this issue had "Ready to work" status, and that previous person @leonardohof had stopped working on it.

bitsikka on 1 Mar 2019

@bitsikka no worries, you can continue working on this because to be honest my PR is still in the works as I'm still learning the code. So go ahead and knock this one out 😃

mul1sh on 1 Mar 2019

@mul1sh thanks! I'm also still learning 😄 and this is going to be my first PR.

bitsikka on 1 Mar 2019

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

__Work for 230.0 DAI (230.0 USD @ $1.0/DAI) has been submitted by__: