Status-react: No dot/comma is shown on keyboard when requesting/sending funds

[asemiankevich]

Description

_Type_: Bug

_Summary_: No dot/comma displayed on keyboard, so can't request or send decimal amount

Expected behavior

Actual behavior

Reproduction

• Open Status
• Go to Wallet
• Click Request
• Observe keyboard shown

Additional Information

• Status version: 0.9.10-433-g25ec3602+ (1990)
• Operating System: Android

Logs

TF: https://app.testfairy.com/projects/4803622-status/builds/7246163/sessions/4/?accessToken=XMMInuMJvGuHON--jIcXYCQ56uc

[yenda]

Reminder for me : https://github.com/facebook/react-native/issues/12988

[yenda]

Fixed in the branch

[asemiankevich]

Fixed in branch 0.9.10-438-g6948dd17+

[yenda]

@asemiankevich can you list the devices that encounter this issue as well as the language in which it happens, this is important for this issue. For a device on which the bug is present please try with english US and french or russian

[yenda]

@asemiankevich is it still happening ?

[asemiankevich]

@yenda yes, it was in place some time ago (couple of weeks) , however i do not own the device now so cant say for sure. @yevh-berdnyk Zhenya, could you please check it?

[denis-sharypin]

@yenda Maybe if we specify a KeyboardType to Numeric it will work properly?

[Serhy]

I can confirm the issue is still present on Samsung Galaxy Note 4 (with Android 6.0.1).
Tried with English (us), English (uk), French, Russian as @yenda suggested - in all cases, there is no delimiter button on Wallet screen for numeric keyboard:

[yevh-berdnyk]

LG V20, Android 7.0 - without delimiter

[Roger--Han]

we fix this issue by adding inline js autocapitalize="off" to the input field, <input type="number" autocapitalize="off">, if this still cannot help you have to set the type to "tel" and only allow user to type 1234567890 and .

[Serhy]

I've noticed one thing: in Dapp (Oasis Direct) on the affected device (Galaxy Note 4) numeric fields request numeric keyboard with a dot as separator.
So in Wallet it (still) looks like:

And this is the same device and OS but in Oasis Direct:

@goranjovic what's the diference between two: requesting numeric keyboard in numeric field in Wallet (e.g. Send -> Specify amount) and numberic keyboard requested from Dapp (Oasis Direct)?

[status-github-bot[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[status-github-bot[bot]]

This issue has been automatically closed. Please re-open if this issue is important to you.

[mandrigin]

@goranjovic @asemiankevich maybe we can make a bounty out of this bug instead?

[phillbaker]

It seems like this should have been solved with decimal-pad support on android: facebook/react-native#19714, however, I was not able to get decimal-pad to work on a physical LG Stylo 3 (Android 7.0) - there was no difference between decimal-pad and numeric.

However, phone-pad does give access to a decimal, so that seems like a decent workaround.

[AnnuRArya]

Anyone fixed the issue on Samsung ? I have set to Editext in Xamarin.Android
```
android:inputType="numberDecimal"
android:capitalize="none"
`````
and in Dutch the keyboard still shows '.' and no ','

[churik]

@Serhy would you mind to recheck it when you have time?
I can't start app on Android 6 in BrowserStack, it is crashed

[Serhy]

Yes, it's still present in Release 1.0.1 build:

[richard-ramos]

@churik, @Serhy
Is this still an issue? Currently that input field is set as "numeric" as seen on this line https://github.com/status-im/status-react/blob/37028c62a2433067122be126db1183ec4addc487/src/status_im/ui/screens/wallet/send/views.cljs#L104 which according to this guide https://lefkowitz.me/visual-guide-to-react-native-textinput-keyboardtype-options/ should display the keyboard

On my phone and simulator it displays the dot/comma

[Serhy]

@richard-ramos yes, it's still an issue (same like in on real https://github.com/status-im/status-react/issues/2681#issuecomment-591486481)
I see it on real device Samsung Galaxy Note 4 with Android 6.0.1

Here is the video of numeric keyboard view in Status and in Chrome(used Airswap dapp):
https://drive.google.com/file/d/1X1e7-JR7TT9mWqoNqVhWDwA6WZt5kSr6/view?usp=sharing

Here is keyboard_galaxy_note_4_in_status.txt for when I tap Send button in Status (so keyboard without delimeter appears) and logs keyboard_galaxy_note_4_chrome-brows.txt for when I tap in input of Dapp to call numeric keyboard