Standard-version: Preserve formatting of package.json

[nexdrew]

See discussion in #38, which was originally meant to address #37 but ended up in a slippery slope of scope creep.

Basically, we overwrite package.json using JSON.stringify(pkg, null, 2) + '\n' but this may be too intrusive for folks using Windows line endings (\r\n instead of \n) or different indentation (tabs instead of spaces, or more than 2 spaces).

Here are a couple ways we could address this:

1. Detect and preserve newline chars and indentation via detect-newline and detect-indent (similar to #38)
2. Read package.json as string (instead of require()ing it) and just replace the "version" value, ignoring/preserving all other content/formatting

I think I'd prefer option 2.

I also think our CHANGELOG writing logic should not be affected by this.

[stevemao]

Probably should be similar to how npm-version does it.

[bcoe]

@nexdrew might be worth looking at how greenkeeper does it.

[nexdrew]

Looks like npm version pretty much does the same thing that standard-version does. Hmm, maybe this is a non-issue then...

[stevemao]

Is this still an issue?

[nexdrew]

@stevemao I think we can close this. If anyone complains we can revisit.

[ArmandoAssuncao]

@nexdrew I'm having problems with this, I use 4 spaces in the package.json, but it's changing to 2 spaces.
Could preserve the file, how you said.

tested in v4.3.0

[stevemao]

I think we should reopen this since npm preserves the format now.

[hugomrdias]

please preserve the code format, we are always fixing conflicts on package.json

[rdbmax]

Can I submit a pull request for this ? Which option do you prefer ?

Read package.json as string (instead of require()ing it) and just replace the "version" value, ignoring/preserving all other content/formatting

I am agree with this

[alasdairhurst]

I've been looking for this for a while, so just got around to creating a PR for this: #282
It's basically a mix of both suggestions and is the same solution npm uses to preserve the format.

[bcoe]

@alasdairhurst @nexdrew is this still something anyone would like to take on?

[alasdairhurst]

@bcoe see the linked PR I provided - it's already merged by you and released in 5.0.0!

[alasdairhurst]

@bcoe this can be closed.