Stackage: hledger-lib-1.12 test build failure

[alexeyzab]

Hledger/Read/JournalReader.hs:85:1: error:
    Could not load module ‘System.FilePath.Glob’
    It is a member of the hidden package ‘Glob-0.9.3’.
    You can run ‘:set -package Glob’ to expose it.
    (Note: this unloads all the modules in the current scope.)
   |
85 | import "Glob" System.FilePath.Glob hiding (match)
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Going to skip the tests in the meantime. CC @simonmichael

[simonmichael]

@alexeyzab, can you see why it thinks Glob is hidden ? It is in the build-depends for the library and for both test suites in the cabal file, http://hackage.haskell.org/package/hledger-lib-1.12/hledger-lib.cabal.

[simonmichael]

I see it's because Glob is hidden in build-constraints.yaml, in favour of the older filemanip package which exposes the same module. I've opened #4206 suggesting this be reversed.

[qrilka]

@alexeyzab it looks that according to Dan's comment in https://github.com/GaloisInc/cereal/issues/81#issuecomment-450394855 this problem should go into expected-test-failures and not skipped-tests or maybe I miss something?

[juhp]

@qrilka not really: skipped-tests are for build failures - expected failures are for tests failing.

[juhp]

I will close this for now and re-open if there should still be a problem in Nightly, thanks!

[DanBurton]

skipped-tests are for build failures - expected failures are for tests failing.

@juhp this contradicts what I said in https://github.com/GaloisInc/cereal/issues/81#issuecomment-450394855.

[juhp]

Thanks, I see, I think it would be better to clarify the comments above the expected-test-failures section then: it's confusing to me anyway.