Sponge: Listeners GameRegistryEvent.Register<DataTranslator<?>> never calling

[Lignium]

I am currently running

• SpongeVanilla version: spongevanilla-1.12.2-7.1.4
• Java version: OpenJDK 1.8.0_181
• Operating System: Kubuntu 18.04
• Plugins/Mods: Only one experimental plugin

Issue Description

Listeners GameRegistryEvent.Register<DataTranslator<?>> never calling and impossible to register correctly DataTranslators.

[Cybermaxke]

Right now it's not allowed to register custom DataTranslators.
https://github.com/SpongePowered/SpongeCommon/blob/stable-7/src/main/java/org/spongepowered/common/registry/type/data/DataTranslatorRegistryModule.java#L99

[Lignium]

I need to serialize to DataContainer instances of a regular class that is not associated with Data API. DataTranslator is best suited for this. It is very important that this happens automatically when calling the appropriate methods in DataView class. Why then need DataManager#registerTranslator() method? The fact that the event is not triggered is more like a bug.

[Cybermaxke]

For now use the DataManager#registerTranslator() method, I will fix it when I have the time.

[Lignium]

There is another problem... Work of methods DataManager#registryTranslator() and GameRegistryEvent.Register#register() somewhat different. When registering a DataTranslator with GameRegistryEvent.Register#register() then methods DataView#getObject() and DataView#getObjectList() can't get data translator.

In practice, it is not yet possible to test, due to the bug described above.

I made a small image illustrating this:

[Cybermaxke]

Yes, I already noticed that the two methods are currently doing different things.

[Cybermaxke]

@Lignium The event should work now as expected.