Sponge: Gamerules not being respected in custom worlds

[jeffreykog]

When creating a custom world, calling WorldProperties.setGameRule("doMobSpawning", "false"), still spawns mobs in the generated world.
Vanilla minecraft shares the GameRules between each world. This way, sponge has no control over gamerules in other worlds.

[jeffreykog]

Adding to that, the /gamerule command always changes and views gamerules for the default world only

[Zidane]

Handling this isn't cut and dry.

Some would argue for this affecting only the world executed in. Some would argue it ought to affect all worlds. We have a split mind happening in the current codebase as some commands affect all worlds, some affect only the one executed in.

I'm leaning towards returning to Vanilla spec and having it affect all worlds but with an optional mixin plugin (which there is a PR for on SpongeCommon) that turns the Vanilla commands into ones that are multi-world friendly. Though even with that, I am tempted to keep it Vanilla-only in Sponge itself and let your commands plugin you are likely using handle doing per-world variants.

@SpongePowered/developers

Could use some feedback here.

[Deamon5550]

A default-on mixin plugin making the vanilla commands multi-world friendly is in my opinion the most user friendly option.

[jeffreykog]

As long as the gamerule checks are performed on the worlds that those rules apply to, then it can indeed be on a commands to decide how to handle the commands. That works for me