Spoke: BUG: Wrong Link for Heroku Production Infrastructure Deploy

[jb-cloud]

In all the docs regardless of version the links for a prod infrastructure deploy all point to the same template:

https://heroku.com/deploy?template=https://github.com/MoveOnOrg/Spoke/tree/heroku-button-paid

[ibrand]

Hey @jb-cloud ! We updated the code on that branch every time we cut a new release. Are you noticing that you get an older version when you click the link? Or are you noticing that it's always the same url?

The only difference between main and heroku-button-paid is that heroku-button-paid has a different app.json that deploys with paid infra

[jb-cloud]

Hey @ibrand! Thanks for taking a look.

I'm noticing the link, only for paid infra is always the same. Differently, the links attached to the pretty Heroku buttons are different for each version.

paid: https://heroku.com/deploy?template=https://github.com/MoveOnOrg/Spoke/tree/heroku-button-paid
free: https://heroku.com/deploy?template=https://github.com/MoveOnOrg/Spoke/tree/v8.1
free: https://heroku.com/deploy?template=https://github.com/MoveOnOrg/Spoke/tree/v8.0
free: https://heroku.com/deploy?template=https://github.com/MoveOnOrg/Spoke/tree/v7.0

[ibrand]

Ok yes so @jb-cloud I'll explain this part of our deploy process and why that is and that should clear this up. Once everything looks stable in a release and it's been merged into main and tagged as a new release, we merge main into heroku-button-paid and push that up so that it has the latest changes.

The reason that heroku-button-paid even exists is that it has one file that is different from main -- the app.json file. This is because app.json has the infrastructure that Heroku deploys with and we didn't want the default on main to charge folks ~$100 just to demo Spoke. That means that everytime we release, we update that branch to the latest version.

Does that make sense?

[Frydafly]

@jb-cloud Is this issue ok to close?

[jb-cloud]

@Frydafly I will check today. The issue was that the paid button wasn’t
deploying main it was deploying and older version.

On Sun, Mar 14, 2021 at 11:07 AM Frydafly @.*> wrote:

@jb-cloud https://github.com/jb-cloud Is this issue ok to close?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MoveOnOrg/Spoke/issues/1777#issuecomment-798923491,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGHPYFIUQEZHGYCROYKGYULTDTGKBANCNFSM4QL2KANA
.

[Frydafly]

Thanks @jb-cloud!