Sparkle: Build of 1.22.0 fails with ld: library not found for -lbsdiff

[mbacchi]

When building Sparkle 1.22.0, the bsdiff vendor library doesn't seem to be built prior to trying to use it. The error is:

Ld /Users/user1/sparkle/build/Release/Sparkle.framework/Versions/A/Sparkle normal x86_64 (in target: Sparkle)
    cd /Users/user1/sparkle
    export MACOSX_DEPLOYMENT_TARGET=10.7
    /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -arch x86_64 -dynamiclib -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk -L/Users/user1/sparkle/build/Release -F/Users/user1/sparkle/build/Release -filelist /Users/user1/sparkle/build/Sparkle.build/Release/Sparkle.build/Objects-normal/x86_64/Sparkle.LinkFileList -install_name @rpath/Sparkle.framework/Versions/A/Sparkle -Xlinker -rpath -Xlinker @executable_path/../Frameworks -Xlinker -rpath -Xlinker @loader_path/Frameworks -mmacosx-version-min=10.7 -dead_strip -Xlinker -object_path_lto -Xlinker /Users/user1/sparkle/build/Sparkle.build/Release/Sparkle.build/Objects-normal/x86_64/Sparkle_lto.o -fobjc-arc -fobjc-link-runtime -Wl,-U,_NSURLQuarantinePropertiesKey -framework AppKit -framework Foundation -framework IOKit -lbsdiff -lbz2 -led25519 -lxar.1 -lz -framework Security -framework SystemConfiguration -framework WebKit -compatibility_version 1.6 -current_version 1.22.0 -Xlinker -dependency_info -Xlinker /Users/user1/sparkle/build/Sparkle.build/Release/Sparkle.build/Objects-normal/x86_64/Sparkle_dependency_info.dat -o /Users/user1/sparkle/build/Release/Sparkle.framework/Versions/A/Sparkle
ld: library not found for -lbsdiff
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Should this be built manually prior to the make build step?

Any instructions would be appreciated.

[kornelski]

Did you clone the repo with --recursive flag?

[mbacchi]

We didn't originally when I opened this issue. Have worked around it by using git submodule update --init and adding a dependency to the Sparkle xcode project for bsdiff/ed25519. This commit is in our fork here.

I'll close this issue as its not blocking us any longer, but wanted to document the solution for others.

[dmitry-kovba]

Please reopen this issue because it's not fixed in the original repository. @mbacchi Please create a PR to add the dependency.