Spaceship-prompt: kubecontext default color not set

[salmanulfarzy]

Introduced with #576

Default value of SPACESHIP_KUBECONTEXT_COLOR_GROUPS sets the color to () and overrides SPACESHIP_KUBECONTEXT_COLOR.

Current behavior

Expected behavior

Relevant Zsh configuration (.zshrc)

SPACESHIP_PROMPT_ORDER=(dir kubecontext line_sep char)

Environment

Spaceship version: https://github.com/denysdovhan/spaceship-prompt/commit/4a7aaf8769e171909febbd52ae2938525cf808ae
Zsh version: 5.5.1
Zsh framework: None
Zsh plugin manager: None

Trace

+spaceship_kubecontext:15> local section_color i color pattern
+spaceship_kubecontext:16> local len=1
+spaceship_kubecontext:18> i = 1
+spaceship_kubecontext:18> i <= 1
+spaceship_kubecontext:19> color='()' 
+spaceship_kubecontext:20> pattern='' 
+spaceship_kubecontext:21> [[ "$kube_context" -regex-match "$pattern" ]]
+spaceship_kubecontext:22> section_color='()' 
+spaceship_kubecontext:23> break
+spaceship_kubecontext:27> [[ -z '()' ]]
+spaceship_kubecontext:29> spaceship::section '()' 'at ' '☸️  spaceship-testing' ' '

Possible solution

• Exit loop if length of array is 1, Since we require at least pair of values (color-pattern) to check for pattern.

// @maximbaz @nomaed

[denysdovhan]

Why it wasn't checked before merging?

[salmanulfarzy]

Had trouble setting up testing environment while doing review due to local issues. Identified this as soon as I was able to test it out locally.

[nomaed]

It was tested, technically. At length even. But then different approaches were tried and it wasn't retested... Sorry, gonna submit a fix in a moment.

There's a weird thing now that SPACESHIP_KUBECONTEXT_SHOW is "false" even if I explicitly set it to "true" in my .zshrc... Trying to find where it can come from.