Spaceship-prompt: [Battery] Battery Icon won't turn off.

[Vvkmnn]

Issue

Battery icon won't disappear, despite being switched off in the .zshrc.

Sample of my .zshrc:

# Spaceship
...
SPACESHIP_BATTERY_SHOW=false
SPACESHIP_BATTERY_ALWAYS_SHOW=false
...

Battery appears to work correctly (only showing up at 100% or below 10%), just insists on staying even when switched off.

Screenshot

Environment

Operating system: macOS 10.12.6
Terminal emulator: iTerm2 3.0.15
ZSH version: zsh 5.2 (x86_64-apple-darwin16.0)

Relevant .zshrc

Full .zshrc available in my dotfiles.

[denysdovhan]

@sfarzy could you check this?

[maccius]

I am having the same issue, with a slightly different config:
macOS 10.12.6
Iterm Build 3.1.20170821-nightly
zsh 5.4.1 (x86_64-apple-darwin16.7.0)

I have also set SPACESHIP_BATTERY_SHOW=false and SPACESHIP_BATTERY_ALWAYS_SHOW=false in my .zshrc.

Screenshot (plugged in):

As with @Vvkmnn, the indicator disappears when actually on battery power (though I haven't confirmed if it shows up again once below 10%).

[salmanulfarzy]

Really sorry for this, It was caused by typo in _BATTERY_SHOW variable.
https://github.com/denysdovhan/spaceship-zsh-theme/blob/84c562879de082aafd4e0725c5b32f0cace12c68/spaceship.zsh#L266
I'm not sure how we missed it 😐

[maccius]

Thanks for the fix!

[Vvkmnn]

Yep, that's fixed it for me too.

Thanks guys.