Sp-dev-fx-webparts: react-page-navigator HTML formatting bug

Created on 7 Aug 2020  路  7Comments  路  Source: pnp/sp-dev-fx-webparts

Sample (which sample are you having trouble with)

react-page-navigator

Authors

@aakashbhardwaj619

Expected or Desired Behavior

The text shouldn't have additional HTML codes such as < br > and < span >. This usually appears before or after the headers.

Observed Behavior

The headers have additional formatting text, which changes when the page is publish. Each time the page is published, the text changes. Below are screenshots of the same webpart but the page has been published twice.

image

image

As you can see, the < br > appears a number of times on the first image and only once in the second image

Steps to Reproduce

  1. Insert text on the page using the text webpart
  2. Select text as Header 1, Header 2, etc.
  3. Insert Page Navigator on right-hand vertical sections
  4. Publish or Republish page.

Environment Details (Development & Target environment)

  • OS: Windows 10
  • Target Environment: SharePoint Online
  • Framework: Node.js v8.15.0
  • Browser(s): Chrome 84, FireFox 79
  • Tooling: VS Code
help wanted bug

Most helpful comment

Hi @nanddeepn , I fixed this and a related issue with broken anchor tags in our tenant as described here: https://github.com/pnp/sp-dev-fx-webparts/issues/1037#issuecomment-672881064
So far, the fix works quite well. Just to let you know. :-)

All 7 comments

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

Hi @hugoabernier
Can I take this up?

Thanks @nanddeepn, the issue is now assigned to you.

Hi @nanddeepn , I fixed this and a related issue with broken anchor tags in our tenant as described here: https://github.com/pnp/sp-dev-fx-webparts/issues/1037#issuecomment-672881064
So far, the fix works quite well. Just to let you know. :-)

@nanddeepn please make sure to mention both this issue and #1037 when you submit your PR so we can mark them both as resolved.

Thanks again for taking this one on!

Hi @nanddeepn , I fixed this and a related issue with broken anchor tags in our tenant as described here: #1037 (comment)
So far, the fix works quite well. Just to let you know. :-)

Thanks @pchaotic and @hugoabernier

Hi @hugoabernier
Submitted PR for this. Please review.

Was this page helpful?
0 / 5 - 0 ratings