Sourcegraph: dev/launch.sh breaks if you haven't run "yarn" yet

Created on 15 Jan 2019  路  4Comments  路  Source: sourcegraph/sourcegraph

All 4 comments

https://github.com/sourcegraph/sourcegraph/pull/1496#issuecomment-452663654

Alternatively we can revert that PR and do "go run" where minversion checks that output of runtime.Version()

I like the go run idea.

Do we expect that some of our contributors (or teammates) use development builds of Go? It seems like there are a lot of complaints about runtime.Version()'s output being unhelpful for this kind of use (https://github.com/golang/go/issues/21207, https://github.com/golang/go/issues/11972, https://github.com/golang/go/issues/11972). I think it's possible to parse release tags well enough, but development builds might be tricky.

I don't think anyone uses a development build of go so I wouldn't worry about that.

Was this page helpful?
0 / 5 - 0 ratings