Sonataadminbundle: Symfony 5 compatibility

[mouad-mahfoud]

I am trying to install sonata admin bundle in a fresh Symfony 5 installation but I get this error :
Problem 1
- Conclusion: don't install sonata-project/admin-bundle 3.56.1
- Conclusion: remove twig/twig v3.0.0
- Installation request for sonata-project/admin-bundle ^3.56 -> satisfiable by sonata-project/admin-bundle[3.56.0, 3.56.1].
- Conclusion: don't install twig/twig v3.0.0
- sonata-project/admin-bundle 3.56.0 requires twig/twig ^2.10 -> satisfiable by twig/twig[v2.10.0, v2.11.0, v2.11.1, v2.11.2, v2.11.3, v2.12.0, v2.12.1, v2.12.2].
- Can only install one of: twig/twig[v2.10.0, v3.0.0].
- Can only install one of: twig/twig[v2.11.0, v3.0.0].
- Can only install one of: twig/twig[v2.11.1, v3.0.0].
- Can only install one of: twig/twig[v2.11.2, v3.0.0].
- Can only install one of: twig/twig[v2.11.3, v3.0.0].
- Can only install one of: twig/twig[v2.12.0, v3.0.0].
- Can only install one of: twig/twig[v2.12.1, v3.0.0].
- Can only install one of: twig/twig[v2.12.2, v3.0.0].
- Installation request for twig/twig (locked at v3.0.0) -> satisfiable by twig/twig[v3.0.0].

[core23]

Feel free to help us supporting symfony 5 @mouad-mahfoud

[michaelKaefer]

@core23 How can we help? Would it be correct to clone the latest version, then upgrade all symfony packages via composer to 5.*, then run the tests and fix all errors? Is that enough? I want to do this in the holidays.

[core23]

Would it be correct to clone the latest version, then upgrade all symfony packages via composer to 5.*, then run the tests and fix all errors?

That's the way you go.

But keep in mind, that we have version lock because of required (dev-)dependencies: https://github.com/sonata-project/SonataAdminBundle/pull/5797#issuecomment-567165651. There are also more third party dependencies that may need an update to work with symfony 5

I want to do this in the holidays.

:100: !

[michaelKaefer]

I think this is too much for me, sorry, somebody else has to do it..

[Bodarev]

https://github.com/sonata-project/SonataAdminBundle/issues/5786#issuecomment-567935452

help please

[core23]

Feel free to help with this by contributing @Bodarev

[MrPoliteGrizlyM]

Have same problem, but with assets:

Problem 1
    - sonata-project/admin-bundle 3.56.1 requires symfony/asset ^3.4.30 || ^4.2 -> no matching package found.
    - sonata-project/admin-bundle 3.56.0 requires symfony/asset ^3.4.30 || ^4.2 -> no matching package found.
    - Installation request for sonata-project/admin-bundle ^3.56 -> satisfiable by sonata-project/admin-bundle[3.56.0, 3.56.1]. 

[VincentLanglet]

I am trying to install sonata admin bundle in a fresh Symfony 5 installation but I get this error :
Problem 1

• Conclusion: don't install sonata-project/admin-bundle 3.56.1
• Conclusion: remove twig/twig v3.0.0
• Installation request for sonata-project/admin-bundle ^3.56 -> satisfiable by sonata-project/admin-bundle[3.56.0, 3.56.1].
• Conclusion: don't install twig/twig v3.0.0
• sonata-project/admin-bundle 3.56.0 requires twig/twig ^2.10 -> satisfiable by twig/twig[v2.10.0, v2.11.0, v2.11.1, v2.11.2, v2.11.3, v2.12.0, v2.12.1, v2.12.2].
• Can only install one of: twig/twig[v2.10.0, v3.0.0].
• Can only install one of: twig/twig[v2.11.0, v3.0.0].
• Can only install one of: twig/twig[v2.11.1, v3.0.0].
• Can only install one of: twig/twig[v2.11.2, v3.0.0].
• Can only install one of: twig/twig[v2.11.3, v3.0.0].
• Can only install one of: twig/twig[v2.12.0, v3.0.0].
• Can only install one of: twig/twig[v2.12.1, v3.0.0].
• Can only install one of: twig/twig[v2.12.2, v3.0.0].
• Installation request for twig/twig (locked at v3.0.0) -> satisfiable by twig/twig[v3.0.0].

This is not an issue with Symfony 5 but only Twig 3.
I think two different issues should be created. One for Sf5 and one for Twig 3.

[greg0ire]

Yeah plus, starting with just Twig 3 might be easier.

[jorrit]

It is clear that Sonata Admin doesn't work with Symfony 5. Until support is added, perhaps a warning could be added to the installation instructions? I can submit a PR for this, but first I'd like to know if this sounds like a good idea.

[core23]

It is clear that Sonata Admin doesn't work with Symfony 5. Until support is added, perhaps a warning could be added to the installation instructions? I can submit a PR for this, but first I'd like to know if this sounds like a good idea.

If I got you right: You want a warning, that we don't support symfony 5? You have composer for that

[jorrit]

What I mean is that it could be helpful to list somewhere in the docs, let's say at https://sonata-project.org/bundles/admin/3-x/doc/getting_started/installation.html, which Symfony version(s) are supported.

Composer does give warnings when installing on Symfony 5, but the warnings given refer to symfony/asset not being the right version, it does not clearly say what the root problem is: Sonata Admin is compatible with Symfony up to 4, not 5.

Perhaps the message currently given by composer is sufficient for most users, but a small addition to the manual would not hurt, I think.

[core23]

IMHO it's overhead to update two places for every dependency. If we start to list supported symfony versions, we must also list supported versions of php, doctrine, twig, phpunit, ...

[VincentLanglet]

IMHO it's overhead to update two places for every depedency. If we start to list supported symfony versions, we must also list supported versions of php, doctrine, twig, phpunit, ...

I agree

In the initial issue, composer return the following message.

sonata-project/admin-bundle 3.56.0 requires twig/twig ^2.10

This seems pretty clear.

[greg0ire]

If anyone wants to help, here is where to start:

composer why-not twig/twig 3   
jms/translation-bundle       1.4.4   requires  twig/twig (^1.27 || ^2.0)  
sonata-project/block-bundle  3.18.3  requires  twig/twig (^1.34 || ^2.0)  
sonata-project/core-bundle   3.18.0  requires  twig/twig (^1.34 || ^2.0)  
sonata-project/intl-bundle   2.7.0   requires  twig/twig (^2.9)           
twig/extensions              v1.5.4  requires  twig/twig (^1.27|^2.0)

[jaikdean]

As an update to @greg0ire's last comment…

• There is an issue open for updating jms/translation-bundle
• sonata-project/block-bundle 4.0.0 added support for Symfony 4 and Twig 3
• It appears sonata-project/core-bundle is being dropped (see #5906)
• It appears sonata-project/intl-bundle is being dropped (see #5835)
• It appears twig/extensions is abandoned

[VincentLanglet]

• It appears twig/extensions is abandoned

And you created the issue https://github.com/sonata-project/SonataAdminBundle/issues/5909

[greg0ire]

See also:

• https://github.com/schmittjoh/JMSTranslationBundle/pull/519
• https://github.com/schmittjoh/JMSTranslationBundle/pull/520

[goetas]

schmittjoh/JMSTranslationBundle#519
schmittjoh/JMSTranslationBundle#520

Both PR have been merged

[greg0ire]

@goetas here is one more : https://github.com/schmittjoh/JMSTranslationBundle/pull/522 :)

[VincentLanglet]

• sonata-project/block-bundle 4.0.0 added support for Symfony 5 and Twig 3

The AdminBundle will need to drop support of 3.x blockbundle to be Symfony is 5 compatible or we'll need to fix some deprecation on the 3.x version.

For example:

The "Sonata\BlockBundle\Event\BlockEvent" class extends "Symfony\Component\EventDispatcher\Event" that is deprecated since Symfony 4.3, use "Symfony\Contracts\EventDispatcher\Event" instead.
    1x in CRUDControllerTest::testList from Sonata\AdminBundle\Tests\Functional\Controller

Does updating the major version of a dependency is a BC-break @greg0ire ?

[jaikdean]

The AdminBundle will need to drop support of 3.x blockbundle to be Symfony is 5 compatible or we'll need to fix some deprecation on the 3.x version.

AdminBundle will need to add support for 4.x of BlockBundle. It wouldn't necessarily need to drop support for 3.x.

[VincentLanglet]

Oh yeah indeed.
It will use both Symfony 5 and BlockBundle 4 or both Symfony 4 and BlockBundle 3.

[bhyassine]

So it is not possible yet to install Sonata on a Symfony 5 that uses Twig 3?

[VincentLanglet]

So it is not possible yet to install Sonata on a Symfony 5 that uses Twig 3?

No

[greg0ire]

Does updating the major version of a dependency is a BC-break @greg0ire ?

No it is not.

[parijke]

@greg0ire how can I help?

[VincentLanglet]

@parijke You can run composer why-not

And try to fix one by one the dependency.

For example, the admin-bundle should support block-bundle@5 and stop using the core-bundle. And then, we'll have to fix all the deprecation in the admin-bundle.

[parijke]

@greg0ire dont know exactly what you mean. Can you delegate me some simple tasks or explain what we'll have to do?

[greg0ire]

@parijke I've had a look at the situation on the admin bundle, and it's complicated, because it depends on other bundles… maybe you could start with https://github.com/sonata-project/exporter ? It has no dependencies with sonata bundles.

If I run composer show symfony/* on that project, I get the following list:

symfony/config                     v4.4.5  Symfony Config Component
symfony/console                    v4.4.5  Symfony Console Component
symfony/debug                      v4.4.5  Symfony Debug Component
symfony/dependency-injection       v4.4.5  Symfony DependencyInjection Component
symfony/error-handler              v4.4.5  Symfony ErrorHandler Component
symfony/event-dispatcher           v4.4.5  Symfony EventDispatcher Component
symfony/event-dispatcher-contracts v1.1.7  Generic abstractions related to dispatching event
symfony/filesystem                 v5.0.5  Symfony Filesystem Component
symfony/http-foundation            v4.4.5  Symfony HttpFoundation Component
symfony/http-kernel                v4.4.5  Symfony HttpKernel Component
symfony/inflector                  v5.0.5  Symfony Inflector Component
symfony/mime                       v5.0.5  A library to manipulate MIME messages
symfony/phpunit-bridge             v4.4.5  Symfony PHPUnit Bridge
symfony/polyfill-ctype             v1.14.0 Symfony polyfill for ctype functions
symfony/polyfill-intl-idn          v1.14.0 Symfony polyfill for intl's idn_to_ascii and idn_to_utf8 functions
symfony/polyfill-mbstring          v1.14.0 Symfony polyfill for the Mbstring extension
symfony/polyfill-php72             v1.14.0 Symfony polyfill backporting some PHP 7.2+ features to lower PHP versions
symfony/polyfill-php73             v1.14.0 Symfony polyfill backporting some PHP 7.3+ features to lower PHP versions
symfony/property-access            v4.4.5  Symfony PropertyAccess Component
symfony/routing                    v4.4.5  Symfony Routing Component
symfony/service-contracts          v2.0.1  Generic abstractions related to writing services
symfony/var-dumper                 v5.0.5  Symfony mechanism for exploring and dumping PHP variables
symfony/yaml                       v5.0.5  Symfony Yaml Component

If I ask composer why the config component is not in version 5, I can see that it's only because we don't allow it in composer.json: https://github.com/sonata-project/exporter/blob/2.x/composer.json#L30

Simple task you can do:

1. clone the exporter project
2. make sure you successfully run the tests
3. allow symfony/config 5 and run the test again
4. fix the tests that are broken
5. repeat steps above with symfony/console, and so on.

[greg0ire]

Regarding Twig 3: issues with JMSTranslationBundle are fixed :)

composer why-not twig/twig 3
sonata-project/admin-bundle  3.x-dev  requires  twig/twig (^2.12)          
sonata-project/block-bundle  3.18.4   requires  twig/twig (^1.34 || ^2.0)  
sonata-project/core-bundle   3.18.0   requires  twig/twig (^1.34 || ^2.0)  
twig/extensions              v1.5.4   requires  twig/twig (^1.27|^2.0)

[parijke]

Ok, so I cloned the repo... but then step 2. how do I run the tests?

[VincentLanglet]

Ok, so I cloned the repo... but then step 2. how do I run the tests?

make test works if you have phpunit installed.

But you can use vendor/bin/simple-phpunit too I think

[parijke]

ok, I had to do a composer install before step 2? Otherwise I do not have a vendor directory. Now it outputs:
../vendor/bin/simple-phpunit ExporterTest.php
PHPUnit 8.3.5 by Sebastian Bergmann and contributors.

Testing SonataExporterTestsExporterTest
FFWEEEEE 8 / 8 (100%)

Time: 26 ms, Memory: 6.00 MB

There were 5 errors:

1) SonataExporterTestsExporterTest::testGetResponse with data set #0 ('json', 'foo.json', 'application/json', '#foo#')
Error: Class 'SonataExporterSourceArraySourceIterator' not found

/home/paul/www/exporter/tests/ExporterTest.php:63

2) SonataExporterTestsExporterTest::testGetResponse with data set #1 ('xml', 'foo.xml', 'text/xml', '#foo#')
Error: Class 'SonataExporterSourceArraySourceIterator' not found

/home/paul/www/exporter/tests/ExporterTest.php:63

3) SonataExporterTestsExporterTest::testGetResponse with data set #2 ('xls', 'foo.xls', 'application/vnd.ms-excel', '#foo#')
Error: Class 'SonataExporterSourceArraySourceIterator' not found

/home/paul/www/exporter/tests/ExporterTest.php:63

4) SonataExporterTestsExporterTest::testGetResponse with data set #3 ('csv', 'foo.csv', 'text/csv', '#foo#')
Error: Class 'SonataExporterSourceArraySourceIterator' not found

/home/paul/www/exporter/tests/ExporterTest.php:63

5) SonataExporterTestsExporterTest::testGetResponse with data set #4 ('made-up', 'foo.made-up', 'application/made-up', '##')
Error: Class 'SonataExporterSourceArraySourceIterator' not found

/home/paul/www/exporter/tests/ExporterTest.php:63

--

There was 1 warning:

1) SonataExporterTestsExporterTest::testGetAvailableFormats
Cannot stub or mock class or interface "SonataExporterWriterTypedWriterInterface" which does not exist

--

There were 2 failures:

1) SonataExporterTestsExporterTest::testFilter
Failed asserting that exception message 'Cannot stub or mock class or interface "SonataExporterSourceSourceIteratorInterface" which does not exist' contains 'Invalid "foo" format'.

2) SonataExporterTestsExporterTest::testConstructorRejectsNonTypedWriters
Failed asserting that exception of type "Error" matches expected exception "TypeError". Message was: "Class 'SonataExporterExporter' not found" at
/home/paul/www/exporter/tests/ExporterTest.php:45
.

ERRORS!
Tests: 8, Assertions: 3, Errors: 5, Failures: 2, Warnings: 1.

[VincentLanglet]

ok, I had to do a composer install before step 2? Otherwise I do not have a vendor directory.

Yes. You always have to run composer install if you want to correctly work on a repository ;)

When I

• Clone
• Run composer install
• Run vendor/bin/simple-phpunit

This is what I get

Just run vendor/bin/simple-phpunit in the root of the project ; not in the /tests/ folder @parijke

[parijke]

Ahhhh ok, that worked, same result :-) already learned a few things

[parijke]

So I changed the line
"symfony/config": "^3.4 || ^4.0 || ^5.0", to allow it.... run the tests again, they run fine....

but, is it tested against 5.x then? I don't think so or I do not understand it. composer show:
symfony/config v4.4.5

sorry all, it is a one time investment to get me going I promise :-)

[VincentLanglet]

So I changed the line
"symfony/config": "^3.4 || ^4.0 || ^5.0", to allow it.... run the tests again, they run fine....

but, is it tested against 5.x then? I don't think so or I do not understand it. composer show:
symfony/config v4.4.5

I think you have to run composer update after allowing the v5 in order to install it.

[parijke]

ok, I got all the symfony/* allowed to be 5 and all tests pass. What now?

{
    "name": "sonata-project/exporter",
    "type": "library",
    "description": "Lightweight Exporter library",
    "keywords": [
        "export",
        "csv",
        "xls",
        "data",
        "client"
    ],
    "homepage": "https://github.com/sonata-project/Exporter",
    "license": "MIT",
    "authors": [
        {
            "name": "Thomas Rabaix",
            "email": "[email protected]",
            "homepage": "https://sonata-project.org/"
        }
    ],
    "require": {
        "php": "^7.2"
    },
    "require-dev": {
        "doctrine/dbal": "^2.5",
        "doctrine/orm": "^2.4.5",
        "matthiasnoback/symfony-config-test": "^4.0",
        "matthiasnoback/symfony-dependency-injection-test": "^4.0",
        "propel/propel1": "^1.6",
        "symfony/config": "^3.4 || ^4.0 || ^5.0",
        "symfony/dependency-injection": "^3.4 || ^4.0 || ^5.0",
        "symfony/http-foundation": "^3.4 || ^4.0 || ^5.0",
        "symfony/http-kernel": "^3.4 || ^4.0 || ^5.0",
        "symfony/phpunit-bridge": "^4.3.8 || ^5.0",
        "symfony/property-access": "^3.4 || ^4.0 || ^5.0",
        "symfony/routing": "^3.4 || ^4.0 || ^5.0"
    },
    "suggest": {
        "propel/propel1": "To export propel collections",
        "symfony/property-access": "To be able to export from database entities",
        "symfony/routing": "To be able to export the routes of a Symfony app"
    },
    "config": {
        "sort-packages": true
    },
    "extra": {
        "branch-alias": {
            "dev-master": "2.x-dev"
        }
    },
    "autoload": {
        "psr-4": {
            "Sonata\\Exporter\\": "src/"
        }
    },
    "autoload-dev": {
        "psr-4": {
            "Sonata\\Exporter\\Tests\\": "tests/"
        }
    }
}

PHPUnit 8.5.0 by Sebastian Bergmann and contributors.

Runtime:       PHP 7.3.15-3+ubuntu19.10.1+deb.sury.org+1 with Xdebug 2.9.2
Configuration: /home/paul/www/exporter/phpunit.xml.dist

Testing Sonata Exporter Test Suite
................................................................. 65 / 98 ( 66%)
.................................                                 98 / 98 (100%)

Time: 1.03 seconds, Memory: 42.00 MB

OK (98 tests, 306 assertions)

[VincentLanglet]

Create a PR, seems like there is no breaking change for us

[parijke]

Can you help me with that?

[VincentLanglet]

git checkhout -b myNewBranch
git add theFileIChanged
git commit -m TheMessageOfMyCommit
git push

Then https://help.github.com/en/desktop/contributing-to-projects/creating-a-pull-request

[parijke]

I think I did....
https://github.com/sonata-project/exporter/pull/330

[parijke]

So I think the steps are

1. Fork the repo
2. clone the exporter project
3. composer install
4. make sure you successfully run the tests
5. allow symfony/config 5
6. composer update
7. run the test again
8. fix the tests that are broken
9. repeat steps above with symfony/console, and so on.
10. commit the changes
11. create pull request

[greg0ire]

Thanks for your contribution @parijke ! If you want to try your hand on other repositories, please check out the graph on this issue: https://github.com/sonata-project/dev-kit/issues/216 exporter was easy because it's a leaf node of the dependency graph. You might find other leaf node libraries that are not yet compatible with Symfony 5, and do your thing, that will help a lot!

[parijke]

Yes I want really to help get it ready for symfony 5 (got time as well as I am locked down in Spain for at least two weeks). I looked at the issue/graph but it doesn't make sense to me (yet). Maybe it is easier to delegate some (easy) tasks to me that I can finish with a little help sometimes, like the exporter thing. I learned a few things along the way about runnings tests and the github workflow.
Maybe it is better to discuss this further in slack as well?

[greg0ire]

What I was proposing is that you try exactly what you did for the exporter, but for other libs. You can find the exporter on the graph, it's a leaf node (arrows come to it, but do not come out of it). There are some other leaf nodes on this graph, like for instance https://github.com/sonata-project/GoogleAuthenticator or https://github.com/sonata-project/SonataFormatterBundle. Can you look if those are sf5 compatible, and make them compatible if that's not the case? Don't hesitate to post on our channel in the Symfony Slack if you are stuck.

[adriendarki]

it is still impossible to install it on symfony 5

"Restricting packages listed in "symfony/symfony" to "5.0.*"
Your requirements could not be resolved to an installable set of packages."

" Your equirements could not be resolved to an installable set of packages.

Problem 1
- Installation request for sonata-project/admin-bundle ^3.64 -> satisfiable by sonata-project/admin-bundle[3.64.0].
- sonata-project/admin-bundle 3.64.0 requires symfony/asset ^4.3 -> no matching package found.
"

[VincentLanglet]

it is still impossible to install it on symfony 5

Nobody said it was.

[adriendarki]

it is still impossible to install it on symfony 5

Nobody said it was.

sorry my english is not perfect. I think addition of support symfony 5.0 will result in a compatible

[VincentLanglet]

sorry my english is not perfect. I think addition of support symfony 5.0 will result in a compatible

The support of symfony 5.0 is still not fully added. We are still working on it.
Some of the packages provided by sonata are compatible ; but not all.
Since the admin bundle is using a lot of them, it will certainly be the last bundle compatible with symfony 5.

If you want to make some PR to help us, don't hesitate ;)

[MichaelPerlbach]

Any news on that matter?

[VincentLanglet]

We're working on it, but that's not easy. You can help us if you want.

[MichaelPerlbach]

I would be glad if I could be a useful help for you.
Thing is, I am relatively new to Symfony - and I know nothing about the inner workings of Sonata Admin. But if you have tasks I might be able to do within these boundary conditions tell me!

[wbloszyk]

@MichaelPerlbach
I think you can extract actions from CRUDController.

• CRUDListAction
• CRUDEditAction
• CRUD ...
• ...

@VincentLanglet @core23 WDYT?

[VincentLanglet]

Refactoring is always nice, but I don't see why this would help for Symfony 5 ?

@greg0ire Gave an exemple with sonata-exporter here https://github.com/sonata-project/SonataAdminBundle/issues/5788#issuecomment-599190473

And then ask to do the same for other bundle https://github.com/sonata-project/SonataAdminBundle/issues/5788#issuecomment-600484369.

If we want sonataAdmin to support Symfony 5, we needs that every sonataAdmin dependencies support Symfony 5. So start with the dependencies.

[wbloszyk]

We can't support symfony5 when we use controller.

[VincentLanglet]

Ok, you meant extending AbstractController instead

[wbloszyk]

Ok, you meant extending AbstractController instead

This too. I mean more split CRUDController to improve extending CRUD actions by user. We should not keep do big controller in next major. We probably can't add support for symfony5 in sonata 3.

[VincentLanglet]

I mean more split CRUDController to improve extending CRUD actions by user. We should not keep do big controller in next major.

I disagree. Splitting the CRUDController is not needed for Symfony 5.

What are the minimal changes needed to be symfony 5 compatible, this is only what we should focus on.

[jorrit]

If we want sonataAdmin to support Symfony 5, we needs that every sonataAdmin dependencies support Symfony 5. So start with the dependencies.

Is there an up to date overview of the specific changes that are needed?

[jorrit]

Just to clarify: is it a goal to have Symfony 5 support in Sonata 3? Or is it a goal for Sonata 4?

[VincentLanglet]

@wbloszyk Will be the best to answer this 😅

[wbloszyk]

@VincentLanglet
https://github.com/sonata-project/SonataBlockBundle/issues/700#issuecomment-643262523

[wbloszyk]

@jorrit
In SonataBlockBundle add support for:

• knplabs/knp-menu-bundle ^3.0
• symfony/* ^4.3 || ^5.0

In SonataIntlBundle add support for:

• knplabs/knp-menu-bundle ^3.0
• symfony/* ^4.3 || ^5.0

In SonataAdminBundle add support for:

• knplabs/knp-menu-bundle ^3.0
• doctrine/common ^3.0
• symfony/* ^4.3 || ^5.0

__This change will be probably enought to add this support in this bundles.__

[jorrit]

@wbloszyk : Do you mean version 3 of those three modules? Because SonataBlockBundle already has SF5 support but only in version 4.

[wbloszyk]

Sonata 3 using BlockBundle 3. Add support in Sonata 3 for BlockBundle will be awsome too but much harder.

[jorrit]

So if I understand it correctly, BlockBundle 3 also has to support Symfony 5?

[wbloszyk]

All require dependencies have to support symfony 5 too.

[jorrit]

On https://github.com/sonata-project/SonataAdminBundle/pull/5948#issuecomment-599140668 it was determined that SF 5 compatibility in Sonata 3 is not possible.

[neimheadh]

Hello everyone.

I just forked the project to work on the Symfony 5 compatibility. I don't know a lot about the Sonata admin bundle background, but for the moment I just changed symfony dependencies to "^5.1", and the composer install worked. Of course I have some inheritance errors, I'm working on it, but it seems that the "sonata-project/admin-bundle" sub-dependencies has no problem with SF 5.1.

As I see with the @jorrit comment, you seem to have blocking problems with knp-menus but.. The issue is closed so maybe not. Idk...

Do you have a clear view of SF5-compatibility progress on your side?

[jorrit]

@neimheadh : The issue was closed for the master branch which will one day be Sonata Admin v4 but I am trying to get a statement on whether SF5 support will ever be available for Sonata Admin v3.

[VincentLanglet]

On #5948 (comment) it was determined that SF 5 compatibility in Sonata 3 is not possible.

Only if you can avoid this BC-break.

We try to finish the v4, but it's not easy.

[neimheadh]

@neimheadh : The issue was closed for the master branch which will one day be Sonata Admin v4 but I am trying to get a statement on whether SF5 support will ever be available for Sonata Admin v3.

Yeah I see. Indeed I'm working on master branch. Are you interested I push my change on master when I'll be able to use Sonata (dev-master version) on my project?

[VincentLanglet]

We are really interested by any kind of PR to help us to finish the v4 or to add the Symfony 5 (or twig 3) support.

The current dev-master branch can't be used. And that's a big issue, because we can't test manually any PR on the master branch.

The first step would be to fix this and allow to use both the SonataAdmin and SonataDoctrineORMAdmin dev-master branch together.
I think it's on the @wbloszyk plans, isn't it ?

[neimheadh]

Yes, I also try to make SonataDoctrineORMAdmin dev-master work on SF.5.1. Btw I see that @SonataAdmin/standard_layout.html.twig needs @SonataCore/FlashMessage/render.html.twig and @SonataTwig/FlashMessage/render.html.twig.

Is it a reason for sonata-project/admin-bundle not having sonata-project/core-bundle & sonata-project/twig-extensions dependencies?

[VincentLanglet]

Yes, I also try to make SonataDoctrineORMAdmin dev-master work on SF.5.1. Btw I see that @SonataAdmin/standard_layout.html.twig needs @SonataCore/FlashMessage/render.html.twig and @SonataTwig/FlashMessage/render.html.twig.

Is it a reason for sonata-project/admin-bundle not having sonata-project/core-bundle & sonata-project/twig-extensions dependencies?

It does have twig-extension dependency.
A recent PR removed the Core dependency, I think, by the syntax, it requires @SonataCore/FlashMessage/render.html.twig OR @SonataTwig/FlashMessage/render.html.twig.

[wbloszyk]

Yes, I'm working on it.
@SonataAdmin/standard_layout.html.twig needs
@SonataCore/FlashMessage/render.html.twig __OR__ @SonataTwig/FlashMessage/render.html.twig.

Now I'm working on replace CoreBundle by form- and twig- extensions 0.x. Then upgrade it to extensions 1.x.
https://github.com/sonata-project/dev-kit/issues/697

To finish it i need improve FlashManager:
https://github.com/sonata-project/twig-extensions/issues/89
https://github.com/sonata-project/twig-extensions/pull/90

At the end support the same BlockBundle version is require to allow use Sonata 3 and Sonata 4 together.

[neimheadh]

Yep my mistake, it is @SonataCore/FlashMessage/render.html.twig OR @SonataTwig/FlashMessage/render.html.twig.

So if I got it well @wbloszyk, the CoreBundle will be deprecated in the future in favor of SonataTwig (and some others)?

[wbloszyk]

Correct: https://github.com/sonata-project/SonataCoreBundle#warning-this-bundle-is-deprecated

[neimheadh]

I finally have a working instance on SF5.1. Here what I had to do :

https://github.com/sonata-project/SonataAdminBundle/compare/master...neimheadh:master

• Changed all sonata-project/admin-bundle symfony dependencies from ^4.3 to ^5.1
• Changed sonata-project/admin-bundle twig dependency from ^2.12.1 to ^3.0
• Changed sonata-project/admin-bundle sonata-project/twig-extensions dependency from ^0.1.1 || ^1.3 to 1.x-dev
• Fix sonata-project/admin-bundle inheritance.

https://github.com/sonata-project/SonataDoctrineORMAdminBundle/compare/master...neimheadh:master

• Changed all sonata-project/doctrine-orm-admin-bundle symfony dependencies from ^4.3 to ^5.1
• Added ^3.0 to sonata-project/doctrine-orm-admin-bundle twig dependency
• Changed sonata-project/doctrine-orm-admin-bundle sonata-project/admin-bundle dependency to dev-master

• Required sonata-project/twig-extensions:1.x-dev on my project
• Required sonata-project/doctrine-extensions:1.x-dev on my project

And I'm good, with an empty Sonata project. I don't want to do the PR now as my dependencies changes are a little bit extreme, with no test for the moment of inheritance changes on SF4 and SF5.0. And I also don't know what are your workflow so... Feel free to tell me how to make my PR on your project if you're interested.

[neimheadh]

Hello, it's me again.
Again a little change on AdminBundle fixing exception when I create a new admin on SF5.1 - just changed SymfonyComponentTranslationTranslatorInterface dependency to SymfonyContractsTranslationTranslatorInterface. Also fixed dependencies for CRUDController and FieldDescription:
https://github.com/sonata-project/SonataAdminBundle/compare/master...neimheadh:master

I also allowed null Help one base fields, I don't know if it should be mandatory, but if I follow documentation, it shouldn't be.

[wbloszyk]

Close this issue in favor for https://github.com/sonata-project/SonataAdminBundle/issues/6365