Solidus: White font on white background in active tab on products

Created on 21 Jul 2019  路  7Comments  路  Source: solidusio/solidus

In a vanilla production deployment, the active tab in the product view in the backend has a white font on white background.

Solidus Version:
2.9.0

To Reproduce

  1. Open a product in the shop admin backend.
  2. The Product Details tab which is selected is completely white.
  3. Select any other tab.
  4. The Product Details tab is now grey with the words Product Details shown on it in a darker shade of grey while the tab you just selected is all white now.

Current behavior
Tab label is invisible because foreground and background colour are the same.

Expected behavior
Background colour should have sufficient contrast against the background colour for the label to be legible.

Solidus Admin Waiting on Author Response

All 7 comments

This actually seems to be the same on other tabbed views in the backend.

@jsfan I believe this has been fixed on master in https://github.com/solidusio/solidus/pull/3269

Can you confirm that this is the same issue?

@jacobherrington In #3269 it's a different issue, I attached a screenshot of the issue /cc @mfrecchiami

Screen Shot 2019-07-25 at 2 14 33 PM

Hi guys!
Maybe @jacobherrington wanted to refer to this merged PR: https://github.com/solidusio/solidus/pull/3274

This issue was already solved 馃槈

Thanks for notifying me @octave !

@mfrecchiami oh there you go! Thank you!

We are going to release a new patch version with this fix as soon as possible.

Closing since Solidus 2.9.1 has been released!

Was this page helpful?
0 / 5 - 0 ratings