Solidus: Master Price field should be conditionally required based on Spree::Config[:require_master_price]

[mbreedlove]

Spree::Config exposes a preference, require_master_price, that when set to false, allows saving a master variant without a price.

If require_master_price is set to false, the "Master Price" field on Product#edit should not be required.

Here's the offending line: https://github.com/solidusio/solidus/blob/master/backend/app/views/spree/admin/products/_form.html.erb#L35

[laurawadden]

on it :)

[jhawthorn]

@mbreedlove We tried removing the required field, but it introduced further wrong behaviour. It would take the empty string assigned to price= and consider that a new price of 0.

I haven't run a store with this value set, what is the desired behaviour?

[jacobherrington]

Couldn't recreate this bug in 2.7.

[mdesantis]

This issue seems to have been fixed in https://github.com/solidusio/solidus/commit/0ecd93ea50029b40d90ea9e6d6b7fcb5eb2fc71b