Smokedetector: Smokey Stops reporting the first feedback for posts

Created on 14 Jul 2017  路  9Comments  路  Source: Charcoal-SE/SmokeDetector

I've seen this happen a few times. After a period of not being rebooted, smokey stops adding chat messages in CharcoalHQ like this:
fpglor
Instead, not message appears even though people _have_ provided feedback for the post.

Rebooting smokey seems to fix the problem. I think someone mentioned a websocket timing out when we have discuss this in the past but I can't be sure.

confirmed bug

Most helpful comment

We're going to need to watch to see if this is actually resolved. However, I fixed an issue which would have caused the problem.

The issue I fixed was that after the WebSocket to MS is initially established, if an exception occurred (e.g. an error or the WebSocket was closed by MS), then SD would attempt to re-establish the connection, but would not transmit it's security key, which would cause the attempt to reestablish the WebSocket to fail in a way that caused SD to think that things were OK. Thus, once disconnected, the WebSocket connection would never be actually reestablished.

All 9 comments

This is why I think we should switch to a proper ActionCable client implementation.

Has this happened again recently?

I'll keep an eye out for the next few days. It definitely happened within 2 weeks.

Has this been reproduced recently?

Nope. I haven't seen this recently.

This has started happening again. See the transcript here: https://chat.stackexchange.com/transcript/message/45606961#45606961
and the conversation afterwards.

This issue has been closed because it has had no recent activity. If this is still important, please add another comment and find someone with write permissions to reopen the issue. Thank you for your contributions.

This has been happening fairly often lately, though I don't know for sure if it has increased in frequency. It doesn't seem to depend on which instance of Smokey is being used. Smokey isn't losing its ability to post messages in the room--it still reports posts and replies to commands.

@double-beep has observed that it seems to be triggered by a large number of commands issued in a short time.

We're going to need to watch to see if this is actually resolved. However, I fixed an issue which would have caused the problem.

The issue I fixed was that after the WebSocket to MS is initially established, if an exception occurred (e.g. an error or the WebSocket was closed by MS), then SD would attempt to re-establish the connection, but would not transmit it's security key, which would cause the attempt to reestablish the WebSocket to fail in a way that caused SD to think that things were OK. Thus, once disconnected, the WebSocket connection would never be actually reestablished.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

tripleee picture tripleee  路  4Comments

angussidney picture angussidney  路  9Comments

angussidney picture angussidney  路  8Comments

Tyler-H picture Tyler-H  路  3Comments

tripleee picture tripleee  路  7Comments