Smokedetector: Improvements to auto-blacklist PRs

Created on 4 Nov 2016 · 4Comments · Source: Charcoal-SE/SmokeDetector

I'd like to see if I can make the following improvements to the PRs created by non-code-privileged users when they use the !!/blacklist command:

[x] Link to a MS search for the URL
[x] Link the username to their chat profile
[x] (if possible) automatically search MS and show the number of tps and fps for the site.

blacklists completed feature request

Source

angussidney

Most helpful comment

but would require a lot of code Smokey-side that doesn't have much relevance to spam-detection

I've thought about doing this from the metasmoke side. We could have a webhook from GitHub fired on pull request creation, then embed a comment or something in Smokey PRs that we could pick up on.

Undo1 on 4 Nov 2016

👍5

All 4 comments

The first two are easy enough; the third is just about possible currently but would require a lot of code Smokey-side that doesn't have much relevance to spam-detection...

ArtOfCode- on 4 Nov 2016

but would require a lot of code Smokey-side that doesn't have much relevance to spam-detection

I've thought about doing this from the metasmoke side. We could have a webhook from GitHub fired on pull request creation, then embed a comment or something in Smokey PRs that we could pick up on.

Undo1 on 4 Nov 2016

👍5

Second one (linking user chat profile) is done, see #311 as an example.

Undo1 on 24 Nov 2016

screen shot 2016-11-25 at 10 54 14 pm