Smart_open: Drop support for host/port in S3 URLs

Created on 9 Nov 2019  Â·  1Comment  Â·  Source: RaRe-Technologies/smart_open

What about dropping support for host/port in S3 URLs (endpoint_url may be still provided in transport_params)? It seems this is rarely used feature and these URLs also break RFC rules (like two @ characters in url). Parsing will be much easier without that (parse.urlsplit will be enough).

_Originally posted by @mrk-its in https://github.com/RaRe-Technologies/smart_open/issues/378#issuecomment-551143613_

@piskvorky what do you think?

question

Most helpful comment

I never used that functionality, so no preference either way. Clean and consistent is my general preference – or we'll drown in corner cases.

>All comments

I never used that functionality, so no preference either way. Clean and consistent is my general preference – or we'll drown in corner cases.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

MartinThoma picture MartinThoma  Â·  3Comments

ziky90 picture ziky90  Â·  3Comments

menshikh-iv picture menshikh-iv  Â·  5Comments

piskvorky picture piskvorky  Â·  4Comments

ivan-yankovyi picture ivan-yankovyi  Â·  4Comments