Slide: All visited subreddits showing in offline mode

[lunyx]

Slide version: 5.7.2
Android version: 7.1.2

This has been an issue for at least a year now, even after switching phones. Any subreddit that I've visited shows up on the subreddit list on the side panel even if it doesn't have any offline content. This results in an annoyingly long list to scroll through, making it near impossible to find the subreddit I want while offline. Clearing all offline content does not resolve the issue. I was only able to reset the list by deleting the data directory, resulting in having to sign in all my accounts again and resetting all settings.

[lunyx]

I should also mention that even after clearing data, the issue still persists, which means given some time, I'll have another long list of useless subreddits again.

[lunyx]

Alright, I took a look into this and found that this is being stored under subhistory in /data/data/me.ccrama.redditslide/shared_prefs/SUBSNEW.xml. Under <map>, there is a child node <string name="subhistory">,subreddit1,subreddit2</string>. Deleting subreddits from that list removes it from the side navigation bar in offline mode. However, I don't think it should check there in the first place and should only check what subreddits you have cached for offline use.

[PiwwowPants]

In case someone else looks into it,

• My recommendation for this would be to just filter the sidebar list with getSharedPreferences("cache").getAll().keySet(); rather than create a new shared preference XML. Then this can be an additive change that doesn't hurt current behavior with a if (Reddit.apprestart.getBoolean("forceOffline", "false")) check somewhere
• The values ouput in a Set<String> with each value like "android,0" (/r/android) for the Subreddit so you can just use a replaceAll(",\\d+$", "") to get it in the right format
• Then drop the two CaseInsensitiveArrayList constructors that take params for public CaseInsensitiveArrayList(Collection<String> strings) to get that Set into the right type for comparisons
• Then filter the bar (this is obviously the part I don't want to do)

If no one else looks at this, I will also do that.

[ccrama]

@PiwwowPants I have actually been working on completely re-doing the Slide caching system, using Realm and an extra model layer to connect the Submission and Comment objects as Realm objects. This would make all current code obsolete and fix this issue (was actually a feature) in the process. If you would like to help with that branch, please hit me up!

[Nxt3]

That's awesome. I'll have to look at that. I always thought Realm would be good for Slide

[Tensounder54]

This issue needs to be verified that this is still an issue before any further action can be taken.

[lunyx]

I can confirm that it's still occurring on v5.8.7.

[Tensounder54]

I can confirm that it's still occurring on v5.8.7

Thanks for letting us know @lunyx unfortunately we need to ensure that this is still an issue in the current code base which is Slide version 6.0.1-3.