Slide: "Clear submission history" also clears Read Later

[tp0]

I think this is wrong. It either shouldn't clear, or it should warn the user about it. Maybe it is just me, but "submission history" is pretty ambiguous and I used to think it only clears the visited submissions.

The situation is made even more confusing as Read Later isn't included in the settings backup which "includes history", yet the history clearing feature still counts it as part of the history.

Slide version: 5.6.5.1-alpha4
Android version: 6.0.1

[ccrama]

The settings backup does not include history, as all submissions/read later are stored in an SQLite database on your device that is not backed up (would be a huge file). When you clear posts, it empties the database. Might need some better wording as I can see how that is confusing

[PiwwowPants]

Would you want the clear action to continue to behave that way? As it is now, it looks like history posts are receiving an empty string prefix unless the constructor receives the readLater prefix. Perhaps this class is not doing what I believe it is.
I'm not completely clear on how the database is handled, but could the prefix not be set to something like "history" then this be run on clear to only clear history from the db?

KVStore.getInstance().getByPrefix("history").clear();

[ccrama]

@PiwwowPants that is correct, that would actually be possible and might be a better way of doing this. Will look into it!