Slack: [Feature Request] Create notification on label change

Created on 22 Nov 2019  路  7Comments  路  Source: integrations/slack

In our Slack integration we limit notifications to a certain label. Creating the PR and then changing the label doesn't trigger a notification. It doesn't even trigger the notification if you add a comment later.

Here are the steps to recreate the problem:
1) subscribe to a repo with +label:ready-for-review
2) create a PR without a label
3) attach the label "ready-for-review"
4) notice that there is no notification in Slack for this PR
5) update the PR comment
6) notice that there is still no notification in Slack for this PR

NOTE: This is similar to these issues: #963, #961, #832

Most helpful comment

I wrote the patch for this issue in #1058.
Please help it to merge 馃檶

All 7 comments

Thanks for opening this issue! If you would like to help implement an improvement, read more about contributing and consider submitting a pull request.

This is especially important for OSS projects where contributors have no permissions to add labels and labels have to be added by maintainers after the PR/issue is created. I expect that when a maintainer gets to the PR/issue to triage it and adds a label, that a slack notification also gets sent to notify the rest of the team.

We also use this method in our project. It would be great to have this feature.

I second that, this will be very helpful.

The lack of this feature is currently blocking us from using the slack integration.
We work in a monorepo, and have a bot that auto-adds labels based on the team and directory.
Since that bot runs after the PR is opened (a couple of seconds), the notification isnt sent.

I have also tried adding the label upon opening the PR, using the gh cli by running gh pr create -f -l "ready-for-review", but it is still not sending a notification in this case.

I wrote the patch for this issue in #1058.
Please help it to merge 馃檶

Up for this one, it will be really helpful to be integrated ;)

Was this page helpful?
0 / 5 - 0 ratings

Related issues

campbellssource picture campbellssource  路  3Comments

jchuerva picture jchuerva  路  5Comments

mbbroberg picture mbbroberg  路  5Comments

bkeepers picture bkeepers  路  5Comments

dgellow picture dgellow  路  4Comments