Skywalking: An exception thrown with using the startup.bat boot script on windows

[yang-xiaodong]

• Why do you submit this issue?
• [ ] Question or discussion
• [x] Bug
• [ ] Requirement
• [ ] Feature or performance improvement

---

Bug

• Which version of SkyWalking, OS and JRE?

Skywalking version: 5.0.0-alpha
OS version: win10
JRE: 1.8.0_151

• Which company or project?

I'm the .NET Core Community members, our project will using Skywalking.

• What happen?

When I ran the skywalking startup.bat script on Windows, there's an error occurred, my environment variable has configured Java_Home correctly.

I run the startup.bat using the Cmder app like:

G:\apache-skywalking-apm-incubating\bin
λ startup.bat

I got the following error:

错误: 找不到或无法加载主类 C:\Program Files\Java\jdk1.8.0_151\bin\java


Current directory:
G:\apache-skywalking-apm-incubating\bin

Command to be executed:
"C:\Program Files\Java\jdk1.8.0_151\bin\java.exe"  "C:\Program Files\Java\jdk1.8.0_151"\bin\java  ""-Xms256M -Xmx512M -Dcollector.logDir=G:\apache-skywalking-apm-incubating\bin\.\..\logs"" -cp "G:\apache-skywalking-apm-incubating\bin\.\..\collector-libs\*;G:\apache-skywalking-apm-incubating\bin\.\..\config;.;" org.apache.skywalking.apm.collector.boot.CollectorBootStartUp

ConEmuC: Root process was alive less than 10 sec, ExitCode=1.
Press Enter or Esc to close console...

and

错误: 找不到或无法加载主类 C:\Program Files\Java\jdk1.8.0_151\bin\java


Current directory:
G:\apache-skywalking-apm-incubating\bin

Command to be executed:
"C:\Program Files\Java\jdk1.8.0_151\bin\java.exe"  "C:\Program Files\Java\jdk1.8.0_151"\bin\java   -jar G:\apache-skywalking-apm-incubating\bin\.\..\webapp/skywalking-webapp.jar --server.port=8080 --collector.ribbon.listOfServers=127.0.0.1:10800


ConEmuC: Root process was alive less than 10 sec, ExitCode=1.
Press Enter or Esc to close console...

I tried to use the Windows CMD command, which still doesn't work properly.

---

Requirement or improvement

I think I found the reason which cause the problem, I submitted a PR attempt to fix the problem.

[ascrutae]

@yuleyule66 I had tested the script(mine and yours) in windows 10 last night and both of them are work fine. The JAVA_HOME env variable also under C:\Program Files folder in my test environment.

Also I found some strange thing about the error log that you posted.

Command to be executed:
"C:\Program FilesJava\jdk1.8.0_151\binjava.exe" "C:\Program FilesJava\jdk1.8.0_151"\binjava -jar > G:\apache-skywalking-apm-incubating\bin...\webapp/skywalking-webapp.jar --server.port=8080 --> collector.ribbon.listOfServers=127.0.0.1:10800

In general, the java command cannot be execute twice. So could you post the console log that you execute the following command in your test environment

> echo %JAVA_HOME%
> _EXECJAVA="%JAVA_HOME:"=%"\bin\java
> echo % _EXECJAVA%

[ascrutae]

Maybe you can try the following command and it seems works:

> set _EXECJAVA="%JAVA_HOME:"=%"\bin\java
> %_EXECJAVA% -version

But this is not important. The strange thing is the java command executed twice. maybe you turn echo on and post the execute step information to help me to find the reason why the java command executed twice.

[yang-xiaodong]

I think i found the reason , my JAVA_HOME env is C:\Program Files\Java\jdk1.8.0_151\ , The end of the path has a \ symbol, This caused the error. You can try it.

[ascrutae]

1121 can resolve this issue , and thanks for your contributions